<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">While we're whinging:<div class=""><br class=""></div><div class="">- I'm looking at the Discussion page for an MR (<a href="https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904" class="">https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904</a>) and I see a comment Simon made, beginning with "No, I am not!". I wanted a bit more context. So I click on the filename above the Discussion and am warped to the Changes view (<a href="https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853" class="">https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853</a>). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.</div><div class=""><br class=""></div><div class="">- Simon recently posted a bunch of comments in response to a bunch of my comments. I have a thick stack of emails about each individual comment. But when I view the discussion page (<a href="https://gitlab.haskell.org/ghc/ghc/merge_requests/74" class="">https://gitlab.haskell.org/ghc/ghc/merge_requests/74</a>), I can find Simon's comments only buried in the Discussions that I started. There appears to be no way to glean, from the web page, what has happened since last I looked. Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on. Now, the thick stack of emails seems like the only way to do this.</div><div class=""><br class=""></div><div class="">- Is there a way to get a timestamped list of what discussions are resolved? Sometimes it's nice to be able to check that the resolution was what I had hoped for.</div><div class=""><br class=""></div><div class="">- The Changes page has a table of contents on the left. This is useful sometimes. (In this way, GL beats Phab, where it was sometimes hard to find where a certain file is listed when in the middle of a review.) But is there a way to collapse the ToC? Most of the time, I'm focused on the code itself, and the ToC drastically reduces the number of characters per line, when I view diffs side-by-side.<br class=""><div><br class=""></div><div>Thanks!</div><div>Richard</div><div><br class=""></div><div>PS: I well remember how phrustrated I was with Phab when that rolled out, and how I eventually came to appreciate it. I'm being more patient this time around. In retrospect my trouble was more with arcanist than with Phab itself. (Arcanist and I never really got along... we just reached an unsteady truce, and I won't miss it.) I am happy to be using git as the tool now. But it's effortful to figure out efficient workflows in a new space, and I'm grateful for any help here. Thanks.</div><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 10, 2019, at 1:27 PM, Ben Gamari <<a href="mailto:ben@smart-cactus.org" class="">ben@smart-cactus.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" class="">simonpj@microsoft.com</a>> writes:<br class=""><br class=""><blockquote type="cite" class="">| Another issue is that apparently GitLab still sends one email per comment<br class="">| instead of one comment per batch. This will evidently be fixed in GitLab<br class="">| 11.6 [1].<br class=""><br class="">yes that is TERRIBLE. When does 11.6 land?<br class=""><br class=""></blockquote>It is the next release. I will poke our contact to make sure that they<br class="">realize the severity of the issue.<br class=""><br class=""><blockquote type="cite" class="">What I want is to have a batch of comments with an overview message.<br class="">We used that /all the time/ in Phab! For example:<br class=""><br class=""> I like this patch but you might want to think about X and Y.<br class=""> Meanwhile I have added a bunch of detailed comments.<br class=""><br class="">This would fit very well with the "batch of comments in one email" change.<br class=""><br class=""></blockquote>Indeed and upstream agrees. They created a feature request [1] in response<br class="">to my suggestion. I'll make sure that I mention this to our GitLab contact.<br class=""><br class="">Cheers,<br class=""><br class="">- Ben<br class=""><br class=""><br class="">[1] <a href="https://gitlab.com/gitlab-org/gitlab-ee/issues/9145" class="">https://gitlab.com/gitlab-org/gitlab-ee/issues/9145</a><br class=""><br class="">_______________________________________________<br class="">ghc-devs mailing list<br class=""><a href="mailto:ghc-devs@haskell.org" class="">ghc-devs@haskell.org</a><br class="">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<br class=""></div></div></blockquote></div><br class=""></div></body></html>