<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello Simon,</p>
<p>Sorry for my late reply here, My patch that incorporates you're
unused imports fix and some core library updates has recently been
merged. This is likely the cause of the errors/warnings you see.
I've just checked out a recent master and validated. I do see an
unused import in compiler/simplStg/StgLiftLams/LiftM.hs introduced
in a commit from earlier today (b2950e03b5). This needs to be
fixed, but it's easy: <a class="moz-txt-link-freetext" href="https://phabricator.haskell.org/D5374">https://phabricator.haskell.org/D5374</a>.</p>
<p>Baring that, I don't see any other unused imports when I
validate. Looking at the exact error in your email
(libraries/containers/Data/IntSet/Internal.hs:198), I see that the
line of code is outdated. Please double check that you are on the
most recent master (or perhaps b2950e03b5^ to avoid the previously
mentioned unused import). Then, since many submodules have been
bumped, make sure to do a</p>
<p>`git submodule update --init`</p>
<p>I suspect this will fix your validate problems.</p>
<p>Have a great weekend,</p>
<p>David E<br>
</p>
<div class="moz-cite-prefix">On 23/11/2018 14:31, Simon Peyton Jones
via ghc-devs wrote:<br>
</div>
<blockquote type="cite"
cite="mid:AM0PR83MB030811F3ECBB4413826BA6ACADD40@AM0PR83MB0308.EURPRD83.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin-top:6.0pt;
margin-right:0cm;
margin-bottom:6.0pt;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.Code, li.Code, div.Code
{mso-style-name:Code;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:9.0pt;
font-family:"Courier New";}
span.EmailStyle18
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
.MsoPapDefault
{mso-style-type:export-only;
margin-top:6.0pt;
margin-right:0cm;
margin-bottom:6.0pt;
margin-left:0cm;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-family:"Calibri",sans-serif">I’m
getting lots of these failures. Has someone forgotten to do
a submodule update? I’m up to date on a clean head and
have done ‘git submodule update’<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-family:"Calibri",sans-serif">Help!<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-family:"Calibri",sans-serif">Simon<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="Code">libraries/containers/Data/IntSet/Internal.hs:198:1:
error: [-Wunused-imports, -Werror=unused-imports]<o:p></o:p></p>
<p class="Code"> The import of ‘<>’ from module
‘Data.Semigroup’ is redundant<o:p></o:p></p>
<p class="Code"> |<o:p></o:p></p>
<p class="Code">198 | import Data.Semigroup
(Semigroup((<>), stimes), stimesIdempotentMonoid)<o:p></o:p></p>
<p class="Code"> |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^<o:p></o:p></p>
<p class="Code"><o:p> </o:p></p>
<p class="Code">libraries/containers/Data/IntSet/Internal.hs:220:1:
error: [-Wunused-imports, -Werror=unused-imports]<o:p></o:p></p>
<p class="Code"> The import of ‘Data.Foldable’ is redundant<o:p></o:p></p>
<p class="Code"> except perhaps to import instances from
‘Data.Foldable’<o:p></o:p></p>
<p class="Code"> To import instances alone, use: import
Data.Foldable()<o:p></o:p></p>
<p class="Code"> |<o:p></o:p></p>
<p class="Code">220 | import Data.Foldable (Foldable())<o:p></o:p></p>
<p class="Code"> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^<span
style="font-size:12.0pt"><o:p></o:p></span></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
ghc-devs mailing list
<a class="moz-txt-link-abbreviated" href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a>
<a class="moz-txt-link-freetext" href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
David Eichmann, Haskell Consultant
Well-Typed LLP, <a class="moz-txt-link-freetext" href="http://www.well-typed.com">http://www.well-typed.com</a>
Registered in England & Wales, OC335890
118 Wymering Mansions, Wymering Road, London W9 2NF, England </pre>
</body>
</html>