Hi Simon, <div><br></div><div>Sure I'll do that. I'll create the patches later tonight. </div><div><br></div><div>Kind regards, </div><div>Tamar <br><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 24, 2018, 13:35 Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com">simonpj@microsoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="#954F72">
<div class="m_-2378668608344890579WordSection1">
<p class="MsoNormal"><span>Tamar<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Thank you, that’s great!<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>For the ones that need more work, can we mark them as expect-broken, so that they don’t pollute the testsuite output?<u></u><u></u></span></p>
<p class="MsoNormal"><span><br>
Simon<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> <a href="mailto:lonetiger@gmail.com" target="_blank">lonetiger@gmail.com</a> <<a href="mailto:lonetiger@gmail.com" target="_blank">lonetiger@gmail.com</a>>
<br>
<b>Sent:</b> 24 September 2018 07:13</span></p></div></div></div></div></div><div lang="EN-GB" link="blue" vlink="#954F72"><div class="m_-2378668608344890579WordSection1"><div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"><div><div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal"><span lang="EN-US"><br>
<b>To:</b> Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>><br>
<b>Subject:</b> RE: Windows testsuite failures<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Hi Simon,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">I created some patches to fix the majority of these<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://phabricator.haskell.org/D5174" target="_blank">https://phabricator.haskell.org/D5174</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://phabricator.haskell.org/D5175" target="_blank">https://phabricator.haskell.org/D5175</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://phabricator.haskell.org/D5176" target="_blank">https://phabricator.haskell.org/D5176</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">The remaining ones I’ve either pinged the patches that caused the issues or created tickets<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">For them because they’re actual bugs that require a bit more time to find the cause and fix.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://ghc.haskell.org/trac/ghc/ticket/15668" target="_blank">https://ghc.haskell.org/trac/ghc/ticket/15668</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://ghc.haskell.org/trac/ghc/ticket/15669" target="_blank">https://ghc.haskell.org/trac/ghc/ticket/15669</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://ghc.haskell.org/trac/ghc/ticket/15670" target="_blank">https://ghc.haskell.org/trac/ghc/ticket/15670</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><a href="https://ghc.haskell.org/trac/ghc/ticket/15671" target="_blank">https://ghc.haskell.org/trac/ghc/ticket/15671</a><u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">these should bring down the amount of failing tests to about 5.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Kind Regards,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Tamar<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From: </span></b><span lang="EN-US"><a href="mailto:simonpj@microsoft.com" target="_blank">Simon Peyton Jones</a><br>
<b>Sent: </b>Thursday, September 20, 2018 12:05<br>
<b>To: </b><a href="mailto:lonetiger@gmail.com" target="_blank">Phyx</a><br>
<b>Subject: </b>RE: Windows testsuite failures<u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal">Thanks Tamar. I’ll look forward to hearing back<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">S<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Phyx <<a href="mailto:lonetiger@gmail.com" target="_blank">lonetiger@gmail.com</a>>
<br>
<b>Sent:</b> 20 September 2018 12:02<br>
<b>To:</b> Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>><br>
<b>Cc:</b> <a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<b>Subject:</b> Re: Windows testsuite failures<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Hi Simon, <u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks for the email. I haven't been building head much as I'm working on top of some older commits. From a quick look it seems like the plugin ones are probably testisms, the plugins aren't found so likely a missing path entry somewhere. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The linker ones are are weird, I'll need to take a closer look at those, likely culprit is my recent patch, I had been testing in the 32 bit build and didn't notice these. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">There are a few worrying segfault that shouldn't be there on some random tests so I'll take a closer look at those too.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">And the stat changes need to be updated.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The framework failures I don't see on harbormaster, so think they are again a threading artifact. Need to figure out a more effective way to debug these to find a permanent fix. The ones that harbormaster does see are encoding related.
touch is failing on non-ascii names. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I will take a look this weekend. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Kind regards, <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Tamar <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, Sep 20, 2018, 11:33 Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="margin-left:4.8pt">
Hi Tamar<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:4.8pt">
The list of testsuite failure on Windows has grown quite long – see below. Most seem to concern plugins or linking.<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:4.8pt">
Do you know what is going on here? If they can’t be fixed, can we mark them as expect_broken on Windows, so that it’s easier (when developing) to know when I’ve introduced a regression. Currently I have to do a manual diff against a rather long list.<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:4.8pt">
Thanks!<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:4.8pt">
Simon<u></u><u></u></p>
<p class="MsoNormal" style="margin-left:4.8pt">
<u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b>SUMMARY for test run started at Thu Sep 20 00:13:20 2018 GMTST</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b>1:03:11 spent to go through</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 6530 total tests, which gave rise to</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 18728 test cases, of which</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 12206 were skipped</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> </b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 33 had missing libraries</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 6278 expected passes</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 173 expected failures</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> </b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 9 caused framework failures</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 1 caused framework warnings</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 0 unexpected passes</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 31 unexpected failures</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> 7 unexpected stat failures</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> </b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b>Unexpected failures:</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> ghci/linking/dyn/T10955dyn.run T10955dyn [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> ghci/linking/dyn/T10955.run T10955 [bad stderr] (ghci)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> ghci/linking/dyn/T11072gcc.run T11072gcc [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> numeric/should_run/FloatFnInverses.run FloatFnInverses [bad stdout] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T11244.run T11244 [bad stderr] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-change.run plugin-recomp-change [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/T7040_ghci.run T7040_ghci [bad stdout] (ghci)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/linker_unload.run linker_unload [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/linker_error1.run linker_error1 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/linker_error2.run linker_error2 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/T12771/T12771.run T12771 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/T13082/T13082_good.run T13082_good [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/T14611/T14611.run T14611 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> simplCore/should_compile/T7702.run T7702 [exit code non-0] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> rts/T10672/T10672_x64.run T10672_x64 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> libraries/Win32/tests/T4452.run T4452 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins01.run plugins01 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins07.run plugins07 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins09.run plugins09 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins11.run plugins11 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins12.run plugins12 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins13.run plugins13 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins14.run plugins14 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins15.run plugins15 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T10420.run T10420 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T10294.run T10294 [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T10294a.run T10294a [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T12567a.run T12567a [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-pure.run plugin-recomp-pure [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-impure.run plugin-recomp-impure [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-flags.run plugin-recomp-flags [bad exit code] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> </b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b>Unexpected stat failures:</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/compiler/T9872d.run T9872d [stat not good enough] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/compiler/T12425.run T12425 [stat not good enough] (optasm)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/compiler/T12234.run T12234 [stat not good enough] (optasm)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/compiler/T12150.run T12150 [stat not good enough] (optasm)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/should_run/T15226.run T15226 [stat too good] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/should_run/T15226a.run T15226a [stat too good] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> perf/compiler/MultiLayerModules.run MultiLayerModules [stat not good enough] (normal)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> </b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b>Framework failures:</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> ghci/linking/dyn/T10955.run T10955 [ghci] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T11244.run T11244 [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-change.run plugin-recomp-change [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugins07.run plugins07 [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T10420.run T10420 [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/T10294a.run T10294a [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-pure.run plugin-recomp-pure [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-impure.run plugin-recomp-impure [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> plugins/plugin-recomp-flags.run plugin-recomp-flags [normal] (pre_cmd failed: 2)</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> </b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b>Framework warnings:</b><u></u><u></u></p>
<p class="m_-2378668608344890579m3135077884050701491code"><b> . T13701 [numfield-no-expected] (No expected value found for bytes allocated in num_field check)</b><u></u><u></u></p>
</div>
</div>
</blockquote>
</div>
</div>
</div>
<p class="m_-2378668608344890579m3135077884050701491code" style="margin-left:4.8pt"> <u></u><u></u></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
</div>
</div>
</div>
</blockquote></div></div>