<div dir="ltr"><div>Hi Simon,</div><div><br></div><div>The first patch you quoted half-fixed this.</div><div><br></div><div>the patch here: <br></div><div><a href="https://phabricator.haskell.org/D4392">https://phabricator.haskell.org/D4392</a></div><div><br></div><div>should fix whole-fix it. (It at least validates green on windows)<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 8, 2018 at 12:18 PM, Simon Peyton Jones via ghc-devs <span dir="ltr"><<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="#0563C1" vlink="#954F72" lang="EN-GB">
<div class="m_5120243049604301570WordSection1">
<p class="MsoNormal">PS Presumably it’s these commits<u></u><u></u></p>
<p class="m_5120243049604301570Code">commit 00f1a4ab80b201ce15c509126f89c5<wbr>a108786f32<u></u><u></u></p>
<p class="m_5120243049604301570Code">Author: Douglas Wilson <<a href="mailto:douglas.wilson@gmail.com" target="_blank">douglas.wilson@gmail.com</a>><u></u><u></u></p>
<p class="m_5120243049604301570Code">Date: Tue Feb 6 17:27:32 2018 -0500<u></u><u></u></p>
<p class="m_5120243049604301570Code"><u></u> <u></u></p>
<p class="m_5120243049604301570Code"> rts: fix some barf format specifiers.<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Reviewers: bgamari, erikd, simonmar<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Reviewed By: bgamari<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Subscribers: rwbarton, thomie, carter<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Differential Revision: <a href="https://phabricator.haskell.org/D4390" target="_blank">https://phabricator.haskell.<wbr>org/D4390</a><u></u><u></u></p>
<p class="m_5120243049604301570Code"><u></u> <u></u></p>
<p class="m_5120243049604301570Code">commit 4d1c3b72ec27c8e51fb40809bba3ce<wbr>35246a2966<u></u><u></u></p>
<p class="m_5120243049604301570Code">Author: Ben Gamari <<a href="mailto:bgamari.foss@gmail.com" target="_blank">bgamari.foss@gmail.com</a>><u></u><u></u></p>
<p class="m_5120243049604301570Code">Date: Tue Feb 6 13:27:35 2018 -0500<u></u><u></u></p>
<p class="m_5120243049604301570Code"><u></u> <u></u></p>
<p class="m_5120243049604301570Code"> rts: Add format attribute to barf<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Test Plan: Validate<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Reviewers: erikd, simonmar<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Reviewed By: simonmar<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Subscribers: rwbarton, thomie, carter<u></u><u></u></p>
<p class="m_5120243049604301570Code"> <u></u><u></u></p>
<p class="m_5120243049604301570Code"> Differential Revision: <a href="https://phabricator.haskell.org/D4374" target="_blank">https://phabricator.haskell.<wbr>org/D4374</a><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><a name="m_5120243049604301570__MailEndCompose"><u></u> <u></u></a></p>
<span></span>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin:0cm;margin-bottom:.0001pt"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> ghc-devs [mailto:<a href="mailto:ghc-devs-bounces@haskell.org" target="_blank">ghc-devs-bounces@<wbr>haskell.org</a>]
<b>On Behalf Of </b>Simon Peyton Jones via ghc-devs<br>
<b>Sent:</b> 07 February 2018 23:14<br>
<b>To:</b> ghc-devs <<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>>; Phyx <<a href="mailto:lonetiger@gmail.com" target="_blank">lonetiger@gmail.com</a>><br>
<b>Subject:</b> Windows build broken -- help!<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Aargh. Windows build is broken again. Log below. Help!<u></u><u></u></p>
<p class="MsoNormal">Simon<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="m_5120243049604301570Code">"inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith
-optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Wundef -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-<wbr>derivedconstants/header -optc-Iincludes/dist-<wbr>ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS
-optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./<wbr>autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_v\" -optc-DWINVER=0x06000100 -static -O0 -H64m -Wall -fllvm-fill-undef-with-<wbr>garbage -Werror
-Iincludes -Iincludes/dist -Iincludes/dist-<wbr>derivedconstants/header -Iincludes/dist-ghcconstants/<wbr>header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen <wbr>
-O2 -Wcpp-undef -Wnoncanonical-monad-<wbr>instances -c rts/StgPrimFloat.c -o rts/dist/build/StgPrimFloat.o<u></u><u></u></p>
<p class="m_5120243049604301570Code"><u></u> <u></u></p>
<p class="m_5120243049604301570Code">rts\Schedule.c:274:14: error:<u></u><u></u></p>
<p class="m_5120243049604301570Code"> error: unknown conversion type character 'l' in format [-Werror=format=]<u></u><u></u></p>
<p class="m_5120243049604301570Code"> barf("sched_state: %" FMT_Word, sched_state);<u></u><u></u></p>
<p class="m_5120243049604301570Code"> ^~~~~~~~~~~~~~~~<u></u><u></u></p>
<p class="m_5120243049604301570Code"> |<u></u><u></u></p>
<p class="m_5120243049604301570Code">274 | barf("sched_state: %" FMT_Word, sched_state);<u></u><u></u></p>
<p class="m_5120243049604301570Code"> | ^<u></u><u></u></p>
<p class="m_5120243049604301570Code">In file included from C:/code/HEAD-1/inplace/mingw/<wbr>x86_64-w64-mingw32/include/<wbr>stdio.h:1036:0,<u></u><u></u></p>
<p class="m_5120243049604301570Code"> from includes/rts/Flags.h:16,<u></u><u></u></p>
<p class="m_5120243049604301570Code"> from includes/Rts.h:191,<u></u><u></u></p>
<p class="m_5120243049604301570Code"><u></u> <u></u></p>
<p class="m_5120243049604301570Code"> from rts\Schedule.c:11:0: error: <u></u><u></u></p>
<p class="m_5120243049604301570Code">C:/code/HEAD-1/inplace/mingw/<wbr>x86_64-w64-mingw32/include/_<wbr>mingw_print_pop.h:86:18: note: format string is defined here<u></u><u></u></p>
<p class="m_5120243049604301570Code">#define PRIu64 "llu"<u></u><u></u></p>
<p class="m_5120243049604301570Code"> ^<u></u><u></u></p>
<p class="m_5120243049604301570Code"><u></u> <u></u></p>
<p class="m_5120243049604301570Code">rts\Schedule.c:274:14: error:<u></u><u></u></p>
<p class="m_5120243049604301570Code"> error: too many arguments for format [-Werror=format-extra-args]<u></u><u></u></p>
<p class="m_5120243049604301570Code"> barf("sched_state: %" FMT_Word, sched_state);<u></u><u></u></p>
<p class="m_5120243049604301570Code"> ^~~~~~~~~~~~~~~~<u></u><u></u></p>
<p class="m_5120243049604301570Code"> |<u></u><u></u></p>
<p class="m_5120243049604301570Code">274 | barf("sched_state: %" FMT_Word, sched_state);<u></u><u></u></p>
<p class="m_5120243049604301570Code"> | ^<u></u><u></u></p>
<p class="m_5120243049604301570Code">cc1.exe: all warnings being treated as errors<u></u><u></u></p>
<p class="m_5120243049604301570Code">`gcc.exe' failed in phase `C Compiler'. (Exit code: 1)<u></u><u></u></p>
<p class="m_5120243049604301570Code">"inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith
-optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Wundef -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-<wbr>derivedconstants/header -optc-Iincludes/dist-<wbr>ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS
-optc-fno-strict-aliasing -optc-fno-common -optc-Irts/dist/build/./<wbr>autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-DRtsWay=\"rts_v\" -optc-DWINVER=0x06000100 -static -O0 -H64m -Wall -fllvm-fill-undef-with-<wbr>garbage -Werror
-Iincludes -Iincludes/dist -Iincludes/dist-<wbr>derivedconstants/header -Iincludes/dist-ghcconstants/<wbr>header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build -Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen <wbr>
-O2 -Wcpp-undef -Wnoncanonical-monad-<wbr>instances -c rts/Profiling.c -o rts/dist/build/Profiling.o<u></u><u></u></p>
<p class="m_5120243049604301570Code">make[1]: *** [rts/<a href="http://ghc.mk:295" target="_blank">ghc.mk:295</a>: rts/dist/build/Schedule.o] Error 1<u></u><u></u></p>
<p class="m_5120243049604301570Code">make[1]: *** Waiting for unfinished jobs....<u></u><u></u></p>
<p class="m_5120243049604301570Code">make: *** [Makefile:127: all] Error 2<u></u><u></u></p>
<p class="m_5120243049604301570Code">/c/code/HEAD-1$<span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u><u></u></span></p>
</div></div></div>
</div>
</div>
<br>______________________________<wbr>_________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-<wbr>bin/mailman/listinfo/ghc-devs</a><br>
<br></blockquote></div><br></div>