<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.Code, li.Code, div.Code
{mso-style-name:Code;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Ha! They didn’t regress for me. I validated before committing. How strange.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">I agree about keeping it green<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">Simon<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US"><o:p> </o:p></span></a></p>
<span style="mso-bookmark:_MailEndCompose"></span>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> ghc-devs [mailto:ghc-devs-bounces@haskell.org]
<b>On Behalf Of </b>David Feuer<br>
<b>Sent:</b> 28 August 2017 22:13<br>
<b>To:</b> ghc-devs <ghc-devs@haskell.org><br>
<b>Subject:</b> RE: [commit: ghc] master: Adjust test suite stats (a055f24)<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">These were regressions from your simplifier refactoring. Yes, we should investigate. I'll open a ticket this evening, unless someone else gets to it first. But we surely don't want to keep CI red on every commit until then.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div id="composer_signature">
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;color:#575757">David Feuer<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;color:#575757">Well-Typed, LLP<o:p></o:p></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="color:black">-------- Original message --------<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">From: Simon Peyton Jones via ghc-devs <<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a>>
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Date: 8/28/17 4:57 PM (GMT-05:00) <o:p>
</o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">To: <a href="mailto:ghc-devs@haskell.org">
ghc-devs@haskell.org</a> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Subject: RE: [commit: ghc] master: Adjust test suite stats (a055f24)
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
</div>
</div>
<p class="MsoNormal">David, are you sure we want to accept a more than 5% increase in compile time without investigation? What commit caused these increases? Maybe they are readily squashed? Generally we are trying to improve compiler perf not accept it
getting worse!<br>
<br>
Simon<br>
<br>
| -----Original Message-----<br>
| From: ghc-commits [<a href="mailto:ghc-commits-bounces@haskell.org">mailto:ghc-commits-bounces@haskell.org</a>] On Behalf Of<br>
| <a href="mailto:git@git.haskell.org">git@git.haskell.org</a><br>
| Sent: 28 August 2017 19:34<br>
| To: <a href="mailto:ghc-commits@haskell.org">ghc-commits@haskell.org</a><br>
| Subject: [commit: ghc] master: Adjust test suite stats (a055f24)<br>
| <br>
| Repository : ssh://git@git.haskell.org/ghc<br>
| <br>
| On branch : master<br>
| Link :<br>
| <a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske">
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske</a><br>
| ll.org%2Ftrac%2Fghc%2Fchangeset%2Fa055f240aeda538c656a59e810870e6a2ccc2db<br>
| 7%2Fghc&data=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4<br>
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&<br>
| sdata=WH8x1FkDCAmRas%2F5CIxA7PmqDj1zzfqApfyowKlGdfo%3D&reserved=0<br>
| <br>
| >---------------------------------------------------------------<br>
| <br>
| commit a055f240aeda538c656a59e810870e6a2ccc2db7<br>
| Author: David Feuer <<a href="mailto:David.Feuer@gmail.com">David.Feuer@gmail.com</a>><br>
| Date: Mon Aug 28 14:35:19 2017 -0400<br>
| <br>
| Adjust test suite stats<br>
| <br>
| T1969 and T12150 were failing (stat too high)<br>
| <br>
| <br>
| >---------------------------------------------------------------<br>
| <br>
| a055f240aeda538c656a59e810870e6a2ccc2db7<br>
| testsuite/tests/perf/compiler/all.T | 6 ++++--<br>
| 1 file changed, 4 insertions(+), 2 deletions(-)<br>
| <br>
| diff --git a/testsuite/tests/perf/compiler/all.T<br>
| b/testsuite/tests/perf/compiler/all.T<br>
| index 1da2883..cf49981 100644<br>
| --- a/testsuite/tests/perf/compiler/all.T<br>
| +++ b/testsuite/tests/perf/compiler/all.T<br>
| @@ -72,7 +72,7 @@ test('T1969',<br>
| # 2017-03-24 9261052 (x86/Linux, 64-bit machine)<br>
| # 2017-04-06 9418680 (x86/Linux, 64-bit machine)<br>
| <br>
| - (wordsize(64), 16679176, 15)]),<br>
| + (wordsize(64), 19199872, 15)]),<br>
| # 2014-09-10 10463640, 10 # post-AMP-update (somewhat<br>
| stabelish)<br>
| # looks like the peak is around ~10M, but we're<br>
| # unlikely to GC exactly on the peak.<br>
| @@ -87,6 +87,7 @@ test('T1969',<br>
| # 2017-02-01 19924328 (amd64/Linux) Join points (#12988)<br>
| # 2017-02-14 16393848 Early inline patch<br>
| # 2017-03-31 16679176 Fix memory leak in simplifier<br>
| + # 2017-08-25 19199872 Refactor the Mighty Simplifier<br>
| <br>
| compiler_stats_num_field('bytes allocated',<br>
| [(platform('i386-unknown-mingw32'), 301784492, 5), @@ -1110,7<br>
| +1111,8 @@ test('T12150',<br>
| [ only_ways(['optasm']),<br>
| compiler_stats_num_field('bytes allocated',<br>
| [(wordsize(64), 70773000, 5)<br>
| - # initial: 70773000<br>
| + # initial: 70773000<br>
| + # 2017-08-25: 74358208 Refactor the Mighty Simplifier<br>
| ]),<br>
| ],<br>
| compile,<br>
| <br>
| _______________________________________________<br>
| ghc-commits mailing list<br>
| <a href="mailto:ghc-commits@haskell.org">ghc-commits@haskell.org</a><br>
| <a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask">
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask</a><br>
| ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-<br>
| commits&data=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4<br>
| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&<br>
| sdata=j5wIO8m%2FgR3czmSfjpJlzV4HcMbwrI3nU2C98OmMkV0%3D&reserved=0<br>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><o:p></o:p></p>
</div>
</div>
</body>
</html>