<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body><div>These were regressions from your simplifier refactoring. Yes, we should investigate. I'll open a ticket this evening, unless someone else gets to it first. But we surely don't want to keep CI red on every commit until then.</div><div><br></div><div><br></div><div><br></div><div id="composer_signature"><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"><div style="font-size:85%;color:#575757">David Feuer</div><div style="font-size:85%;color:#575757">Well-Typed, LLP</div></div><div><br></div><div style="font-size:100%;color:#000000"><!-- originalMessage --><div>-------- Original message --------</div><div>From: Simon Peyton Jones via ghc-devs <ghc-devs@haskell.org> </div><div>Date: 8/28/17 4:57 PM (GMT-05:00) </div><div>To: ghc-devs@haskell.org </div><div>Subject: RE: [commit: ghc] master: Adjust test suite stats (a055f24) </div><div><br></div></div>David, are you sure we want to accept a more than 5% increase in compile time without investigation? What commit caused these increases? Maybe they are readily squashed? Generally we are trying to improve compiler perf not accept it getting worse!<br><br>Simon<br><br>| -----Original Message-----<br>| From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of<br>| git@git.haskell.org<br>| Sent: 28 August 2017 19:34<br>| To: ghc-commits@haskell.org<br>| Subject: [commit: ghc] master: Adjust test suite stats (a055f24)<br>| <br>| Repository : ssh://git@git.haskell.org/ghc<br>| <br>| On branch : master<br>| Link :<br>| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.haske<br>| ll.org%2Ftrac%2Fghc%2Fchangeset%2Fa055f240aeda538c656a59e810870e6a2ccc2db<br>| 7%2Fghc&data=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4<br>| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&<br>| sdata=WH8x1FkDCAmRas%2F5CIxA7PmqDj1zzfqApfyowKlGdfo%3D&reserved=0<br>| <br>| >---------------------------------------------------------------<br>| <br>| commit a055f240aeda538c656a59e810870e6a2ccc2db7<br>| Author: David Feuer <David.Feuer@gmail.com><br>| Date: Mon Aug 28 14:35:19 2017 -0400<br>| <br>| Adjust test suite stats<br>| <br>| T1969 and T12150 were failing (stat too high)<br>| <br>| <br>| >---------------------------------------------------------------<br>| <br>| a055f240aeda538c656a59e810870e6a2ccc2db7<br>| testsuite/tests/perf/compiler/all.T | 6 ++++--<br>| 1 file changed, 4 insertions(+), 2 deletions(-)<br>| <br>| diff --git a/testsuite/tests/perf/compiler/all.T<br>| b/testsuite/tests/perf/compiler/all.T<br>| index 1da2883..cf49981 100644<br>| --- a/testsuite/tests/perf/compiler/all.T<br>| +++ b/testsuite/tests/perf/compiler/all.T<br>| @@ -72,7 +72,7 @@ test('T1969',<br>| # 2017-03-24 9261052 (x86/Linux, 64-bit machine)<br>| # 2017-04-06 9418680 (x86/Linux, 64-bit machine)<br>| <br>| - (wordsize(64), 16679176, 15)]),<br>| + (wordsize(64), 19199872, 15)]),<br>| # 2014-09-10 10463640, 10 # post-AMP-update (somewhat<br>| stabelish)<br>| # looks like the peak is around ~10M, but we're<br>| # unlikely to GC exactly on the peak.<br>| @@ -87,6 +87,7 @@ test('T1969',<br>| # 2017-02-01 19924328 (amd64/Linux) Join points (#12988)<br>| # 2017-02-14 16393848 Early inline patch<br>| # 2017-03-31 16679176 Fix memory leak in simplifier<br>| + # 2017-08-25 19199872 Refactor the Mighty Simplifier<br>| <br>| compiler_stats_num_field('bytes allocated',<br>| [(platform('i386-unknown-mingw32'), 301784492, 5), @@ -1110,7<br>| +1111,8 @@ test('T12150',<br>| [ only_ways(['optasm']),<br>| compiler_stats_num_field('bytes allocated',<br>| [(wordsize(64), 70773000, 5)<br>| - # initial: 70773000<br>| + # initial: 70773000<br>| + # 2017-08-25: 74358208 Refactor the Mighty Simplifier<br>| ]),<br>| ],<br>| compile,<br>| <br>| _______________________________________________<br>| ghc-commits mailing list<br>| ghc-commits@haskell.org<br>| https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.hask<br>| ell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-<br>| commits&data=02%7C01%7Csimonpj%40microsoft.com%7C382263fbefc643e95a6308d4<br>| ee436098%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636395420551278722&<br>| sdata=j5wIO8m%2FgR3czmSfjpJlzV4HcMbwrI3nU2C98OmMkV0%3D&reserved=0<br>_______________________________________________<br>ghc-devs mailing list<br>ghc-devs@haskell.org<br>http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<br></body></html>