<div dir="ltr">I would rather we <b>didn't</b> accept contributions via github, even for small patches, and instead put more effort into streamlining the Phabricator workflow.<br><ul><li>Adding another input method complicates the workflow, users have to decide which one to use<br></li><li>Github is not integrated with our other infrastructure, while Phabricator is</li><li>Mutliple sources of contributions makes life harder for maintainers</li></ul><p>Let's make the Phabricator workflow easier.<br></p><ul><li>Why not put arc in the repo, or provide a script that automatically downloads it and sets it up?</li><li>I also like the idea of auto-push if validate succeeds. Or a button that you can press on the diff that would do the same thing, so you can get code review first.</li><li>+1 to making the manual easier to build. The same goes for Haddocks; it's really hard to make a simple patch to the docs and test it right now.</li></ul>One other thing that came up but wasn't mentioned in the notes: let's be more prompt about reverting patches that break validate, even if they only break a test. Now that we have better CI support, we can easily identify breaking patches and revert them.<br><div><p></p><p>Cheers</p><p>Simon<br></p></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 24 September 2016 at 02:44, Simon Peyton Jones via ghc-devs <span dir="ltr"><<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="#0563C1" vlink="#954F72" lang="EN-GB">
<div>
<p class="MsoNormal">Friends<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Here are the notes I took from session 2 of the Haskell Implementors Meeting. The bolding is my choice of emphasis.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Simon<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Doc bugs. Two kinds<u></u><u></u></p>
<p style="margin-left:72.0pt">
<u></u><span style="font-family:"Courier New""><span>o<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Typos. Friction stops me<u></u><u></u></p>
<p style="margin-left:72.0pt">
<u></u><span style="font-family:"Courier New""><span>o<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Explanations needed e.g. read/show<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Lightweight pushes<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Make user manual into its own repo, to make it easier to take pull requests. But that makes it harder when making synchronised changes to GHC and user manual.<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u><b>Auto-push</b>: Ability to push to Phab and have it committed automatically if it validates.<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Style guides. Is having a defined style solving a problem we don’t really have? One piece of guidance:
<b><i>adhere to the style of the surrounding code</i></b>. Low priority.<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Docker images. We should have one.<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Remove old documentation!<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Cross compilation is difficult.<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u><b>Have a GHC StackOverflow on <a href="http://haskell.org" target="_blank">haskell.org</a></b> (Jacob Zalewski
<a href="mailto:jakzale@gmail.com" target="_blank">jakzale@gmail.com</a> offers to do this! – thank you). It has a useful new Documentation feature. Eg this would be good for “how do I look up a RdrName to get a Name… there seem to be six different functions that do that”.<u></u><u></u></p>
</div>
</div>
<br>______________________________<wbr>_________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-<wbr>bin/mailman/listinfo/ghc-devs</a><br>
<br></blockquote></div><br></div>