<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body><div>Thanks! Yes, I did mean to reply all.</div><div><br></div><div>-Richard</div><div><br></div><div><br></div><div><br></div><div id="composer_signature"><div style="font-size:85%;color:#575757" dir="auto">Sent via the Samsung Galaxy S7 edge, an AT&T 4G LTE smartphone</div></div><div><br></div><div style="font-size:100%;color:#000000"><!-- originalMessage --><div>-------- Original message --------</div><div>From: lonetiger@gmail.com </div><div>Date: 9/20/16 6:03 PM (GMT-08:00) </div><div>To: Richard Cook <rcook@rcook.org>, Simon Peyton Jones <simonpj@microsoft.com>, ghc-devs@haskell.org </div><div>Subject: RE: Test T12504 on Windows </div><div><br></div></div><div class="WordSection1"><p class="MsoNormal">I believe you forgot to press Reply-All Richard.</p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">In any case a fix is up at <a href="https://phabricator.haskell.org/D2537">https://phabricator.haskell.org/D2537</a></p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">Sorry, should have caught this during review.</p><p class="MsoNormal"><o:p> </o:p></p><p class="MsoNormal">Tamar</p><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p><div style="mso-element:para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal" style="border:none;padding:0in"><b>From: </b><a href="mailto:rcook@rcook.org">Richard Cook</a><br><b>Sent: </b>Tuesday, September 20, 2016 23:35<br><b>To: </b><a href="mailto:lonetiger@gmail.com">Phyx</a><br><b>Subject: </b>Re: Test T12504 on Windows</p></div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">Dear All,</span><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p></o:p></span></p><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">This is the test case that was added to validate the fix to hsc2hs. Here's the commit that added the test case:<o:p></o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><a href="https://git.haskell.org/ghc.git/commitdiff/76286af5c621f032c4afab1f26b992e8ffa7f84d">https://git.haskell.org/ghc.git/commitdiff/76286af5c621f032c4afab1f26b992e8ffa7f84d</a><o:p></o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">Output on Windows should include backslashes, other platforms should use forward slashes. This is keyed off the WINDOWS Makefile variable.<o:p></o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">-Richard<o:p></o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p></div></div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">On Tue, Sep 20, 2016 at 3:10 PM, Phyx <<a href="mailto:lonetiger@gmail.com" target="_blank">lonetiger@gmail.com</a>> wrote:<o:p></o:p></span></p><blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"><p>The new output is correct. </p><p>hsc2hs was patched to fix the error messages it gives. We missed a test it seems. </p><p>I'll update the test output when I get home. </p><p>Thanks Simon, <br>Tamar </p><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p><div><div><div><div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">On Tue, Sep 20, 2016, 23:06 Simon Peyton Jones via ghc-devs <<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>> wrote:<o:p></o:p></span></p></div></div></div><blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"><div><div><div><div><p class="MsoNormal"><span lang="EN-GB">Test hsc2hs/T12504 is failing thus on Windows. Something path-y.</span><span lang="EN-GB"><o:p></o:p></span></p><p class="MsoNormal"><span lang="EN-GB">Simon<o:p></o:p></span></p><p><span lang="EN-GB"> <o:p></o:p></span></p><p><span lang="EN-GB">-{-# LINE 1 "T12504/path/to/T12504.hsc" #-}<o:p></o:p></span></p><p><span lang="EN-GB">-{-# LINE 2 "T12504/path/to/T12504.hsc" #-}<o:p></o:p></span></p><p><span lang="EN-GB">+{-# LINE 1 "T12504\\path\\to\\T12504.hsc" #-}<o:p></o:p></span></p><p><span lang="EN-GB">+{-# LINE 2 "T12504\\path\\to\\T12504.hsc" #-}<o:p></o:p></span></p><p><span lang="EN-GB">*** unexpected failure for T12504(normal)<o:p></o:p></span></p></div></div></div></div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">_______________________________________________<br>ghc-devs mailing list<br><a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br><a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><o:p></o:p></span></p></blockquote></div><p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><br>_______________________________________________<br>ghc-devs mailing list<br><a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br><a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><o:p></o:p></span></p></blockquote></div></div><p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p> </o:p></span></p><p class="MsoNormal"><o:p> </o:p></p></div></body></html>