<div dir="ltr">Hello! Sorry for taking so long on this..<div><br></div><div>I am still struggling with it and feel like I should probably ask for some assistance or guidance at this point.</div><div><br></div><div>I think I am beginning to understand the first half of this: making sure that the inlining information is saved regardless of the optimization level. It seems like I need to change the functions that are called from tidyProgram which take the variable omit_prags?</div><div><br></div><div>However, I am completely lost as to where this inlining takes place.. I have been trying to look at simplifyPgm in SimplCore.hs, but haven't really been able to see where the inlining happens..</div><div><br></div><div>Could anyone give me any suggestions? I'm beginning to wonder if I'm in over my head as this is my first time working on a compiler so almost everything is new to me. On the other hand I'm certainly learning a lot along the way.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 9, 2016 at 8:34 AM, Richard Fung <span dir="ltr"><<a href="mailto:minesasecret@gmail.com" target="_blank">minesasecret@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_quote"><span class="">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Richard Fung</b> <span dir="ltr"><<a href="mailto:minesasecret@gmail.com" target="_blank">minesasecret@gmail.com</a>></span><br>Date: Tue, Aug 9, 2016 at 8:33 AM<br>Subject: Re: Help on first ticket<br></span><div><div class="h5">To: Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>><br><br><br><div dir="ltr">It's been a while but I've been able to spend more time on it recently made some progress.<div><br></div><div>I believe I have an idea of what I need to fix in terms of the generating of ModDetails/ModInfo. First off, please tell me if this is wrong.. it seems like ModDetails is made in mkBootModDetailsTc and tidyProgram. In tidyProgram there are several functions which take omit_prags, which I think is automatically set to True on -O0. These are the things we'll have to change because they are used in mkIface_ to generate the [IfaceDecl] used to make ModInfo in addFingerprints.</div><div><br></div><div>Hopefully I'm understanding that part correctly. However, I'm not really sure how to write a proper test case for this ticket. Also, I think I have an idea of where to start looking for the place the inlining/unfolding happens but pointers definitely wouldn't hurt.</div><div><br></div><div>Thanks and sorry this is taking me so long!</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 24, 2016 at 12:26 PM, Simon Peyton Jones <span dir="ltr"><<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Great. No rush. Yell if you need help.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Simon<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Richard Fung [mailto:<a href="mailto:minesasecret@gmail.com" target="_blank">minesasecret@gmail.com</a><wbr>]
<br>
<b>Sent:</b> 24 June 2016 19:05<br>
<b>To:</b> Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>><br>
<b>Cc:</b> <a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a></span></p><div><div><br>
<b>Subject:</b> Re: Help on first ticket<u></u><u></u></div></div><p></p>
</div>
</div><div><div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
Hi Simon, I am making progress but slowly (I only have time to work on this outside of work unfortunately).<u></u><u></u></p>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
<u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
If this needs to be done soon feel free to reassign it to someone else! Otherwise, while at times I feel like I'm over my head I would like to keep at it.<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
<u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
On Fri, Jun 24, 2016 at 4:20 AM, Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
Richard, did you get on ok?<br>
<br>
Simon<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
<br>
| -----Original Message-----<br>
| From: ghc-devs [mailto:<a href="mailto:ghc-devs-bounces@haskell.org" target="_blank">ghc-devs-bounces@haske<wbr>ll.org</a>] On Behalf Of Ben<br>
| Gamari<br>
| Sent: 04 June 2016 23:20<br>
| To: Richard Fung <<a href="mailto:minesasecret@gmail.com" target="_blank">minesasecret@gmail.com</a>>;
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
| Subject: Re: Help on first ticket<br>
|<br>
| Richard Fung <<a href="mailto:minesasecret@gmail.com" target="_blank">minesasecret@gmail.com</a>> writes:<br>
|<br>
| > Hello! I apologize if this isn't the right place to ask; if it isn't<br>
| > please steer me in the right direction.<br>
| ><br>
| Hi Richard!<br>
|<br>
| > Would anyone be willing to advise me on my first ticket? I've been<br>
| > trying to work on it on and off but haven't made much progress on my<br>
| own.<br>
| ><br>
| > It's ticket #9370: <a href="https://ghc.haskell.org/trac/ghc/ticket/9370" target="_blank">
https://ghc.haskell.org/trac/g<wbr>hc/ticket/9370</a><br>
| ><br>
| Great, I'm happy to hear that someone has picked this one up. I think<br>
| it is a nice choice for a self-contained newcomers project.<br>
|<br>
| > I think I understand the issue conceptually but I don't know where<br>
| to<br>
| > look for the code that needs to be changed..<br>
| ><br>
| I don't know where the code responsible for this is off the top of my<br>
| head, however I can provide some pointers.<br>
|<br>
| So the unfoldings you are looking to preserve come from interface<br>
| files.<br>
| The machinery for all of this is in compiler/iface. IfaceSyn.hs is of<br>
| particular interest and there you will find the definition of<br>
| IfaceUnfolding, which is the unfolding representation which is stored<br>
| in the interface file. Unfoldings live inside of IdInfo values, which<br>
| hold various miscellaneous information which we need to preserve about<br>
| a particular Id (identifier).<br>
|<br>
| There is a somewhat useful comment regarding how IdInfo is treated<br>
| above the definition of IfaceIdInfo in IfaceSyn. In particular it<br>
| seems that interface files for modules compiled with -O0 will have<br>
| their IdInfo fields set to NoInfo. It's not clear what happens when an<br>
| interface file is read. However, grepping for NoInfo reveals a use-<br>
| site in TcIface.tcIdInfo which looks interesting (in particular the<br>
| ignore_prags guard). I think this should be enough to get you going on<br>
| the interface file part of this.<br>
|<br>
| The other part of this ticket is deciding whether to use an unfolding<br>
| when considering whether to inline. This will be done in the<br>
| simplifier (compiler/simplCore). Grepping for "inline" and "unfold" in<br>
| simplCore/Simplify.hs (as well as reading the notes in that file) will<br>
| likely be enough to get you started.<br>
|<br>
| Do let me know if you still feel lost or want to discuss this further.<br>
| I look forward to hearing how it goes.<br>
|<br>
| Cheers,<br>
|<br>
| - Ben<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
| ______________________________<wbr>_________________<br>
| ghc-devs mailing list<br>
| <a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
| <a href="https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.h" target="_blank">
https://na01.safelinks.protect<wbr>ion.outlook.com/?url=http%3a%2<wbr>f%2fmail.h</a><br>
| <a href="https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faskell.org&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7ca1eb3c659f4a4e7b61e808d39c5a125c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2D8TJzAUIrAyMJCh3k8P0u07l2L267Jz5hzPHc56oR4%3d" target="_blank">
askell.org</a>%2fcgi-bin%2fmailman<wbr>%2flistinfo%2fghc-<br>
| devs&data=01%7c01%7csimonpj%<a href="https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f40064d.mgd.microsoft.com&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7ca1eb3c659f4a4e7b61e808d39c5a125c%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=KIjOeLVN%2fHBrSQo4B%2fVQQRBMUyTS5ZThXLW0Q3%2b9iOQ%3d" target="_blank">40<wbr>064d.mgd.microsoft.com</a>%7c5ce47<wbr>a744a1448f<br>
| ff5cb08d38cc666b8%7c72f988bf86<wbr>f141af91ab2d7cd011db47%7c1&sda<wbr>ta=V22RG%2<br>
| fAiO1lD5bLCR%2fXz2jv5QCzYAK5HU<wbr>i6dDaAFQLA%3d<u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal" style="margin-right:0cm;margin-bottom:6.0pt;margin-left:0cm">
<u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>
</div></div></div></div></div><br></div>
</blockquote></div><br></div>