<div dir="ltr">Ok, I've reverted those changes. Sorry for the breakage.<br><div class="gmail_extra"><br><div class="gmail_quote">On 4 July 2016 at 23:44, Simon Peyton Jones <span dir="ltr"><<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="#0563C1" vlink="#954F72" lang="EN-GB">
<div>
<p class="MsoNormal">Simon, Windows is still broken.<u></u><u></u></p>
<p class="MsoNormal">Do you want me to revert both patches, or will you?<u></u><u></u></p>
<p class="MsoNormal">Simon<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p>"inplace/bin/ghc-stage1.exe" -optc-fno-stack-protector -optc-Wall -optc-Werror -optc-Wall -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith
-optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Iincludes -optc-Iincludes/dist -optc-Iincludes/dist-derivedconstants/header -optc-Iincludes/dist-ghcconstants/header -optc-Irts -optc-Irts/dist/build -optc-DCOMPILING_RTS -optc-fno-strict-aliasing
-optc-fno-common -optc-Irts/dist/build/./autogen -optc-Wno-error=inline -optc-O2 -optc-fomit-frame-pointer -optc-g -optc-fno-omit-frame-pointer -optc-g -optc-O0 -optc-DRtsWay=\"rts_thr_debug\" -optc-DWINVER=0x06000100 -static -optc-DTHREADED_RTS -optc-DDEBUG
-O0 -H64m -Wall -fllvm-fill-undef-with-garbage -Werror -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header -Irts -Irts/dist/build -DCOMPILING_RTS -this-unit-id rts -dcmm-lint -i -irts -irts/dist/build
-Irts/dist/build -irts/dist/build/./autogen -Irts/dist/build/./autogen -O2 -O0 -Wnoncanonical-monad-instances -c rts/Linker.c -o rts/dist/build/Linker.thr_debug_o<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>In file included from rts\Linker.c:13:0: error: <u></u><u></u></p>
<p>rts\Linker.c: In function 'ocTryLoad':<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>rts\Linker.c:2566:55: error:<u></u><u></u></p>
<p> error: pointer type mismatch in conditional expression [-Werror]<u></u><u></u></p>
<p> oc->archiveMemberName : oc->fileName));<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>includes\Rts.h:300:53: error:<u></u><u></u></p>
<p> note: in definition of macro 'IF_DEBUG'<u></u><u></u></p>
<p> #define IF_DEBUG(c,s) if (RtsFlags.DebugFlags.c) { s; }<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>rts\Linker.c:2564:33: error:<u></u><u></u></p>
<p> error: format '%ls' expects argument of type 'wchar_t *', but argument 2 has type 'void *' [-Werror=format=]<u></u><u></u></p>
<p> IF_DEBUG(linker, debugBelch("Resolving %" PATH_FMT "\n",<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>includes\Rts.h:300:53: error:<u></u><u></u></p>
<p> note: in definition of macro 'IF_DEBUG'<u></u><u></u></p>
<p> #define IF_DEBUG(c,s) if (RtsFlags.DebugFlags.c) { s; }<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p>cc1.exe: all warnings being treated as errors<u></u><u></u></p>
<p>`gcc.exe' failed in phase `C Compiler'. (Exit code: 1)<u></u><u></u></p>
<p>rts/<a href="http://ghc.mk:255" target="_blank">ghc.mk:255</a>: recipe for target 'rts/dist/build/Linker.debug_o' failed<u></u><u></u></p>
<p>make[1]: *** [rts/dist/build/Linker.debug_o] Error 1<u></u><u></u></p>
<p>make[1]: *** Waiting for unfinished jobs....<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>In file included from rts\Linker.c:13:0: error: <u></u><u></u></p>
<p>rts\Linker.c: In function 'ocTryLoad':<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>rts\Linker.c:2566:55: error:<u></u><u></u></p>
<p> error: pointer type mismatch in conditional expression [-Werror]<u></u><u></u></p>
<p> oc->archiveMemberName : oc->fileName));<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>includes\Rts.h:300:53: error:<u></u><u></u></p>
<p> note: in definition of macro 'IF_DEBUG'<u></u><u></u></p>
<p> #define IF_DEBUG(c,s) if (RtsFlags.DebugFlags.c) { s; }<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>rts\Linker.c:2564:33: error:<u></u><u></u></p>
<p> error: format '%ls' expects argument of type 'wchar_t *', but argument 2 has type 'void *' [-Werror=format=]<u></u><u></u></p>
<p> IF_DEBUG(linker, debugBelch("Resolving %" PATH_FMT "\n",<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>includes\Rts.h:300:53: error:<u></u><u></u></p>
<p> note: in definition of macro 'IF_DEBUG'<u></u><u></u></p>
<p> #define IF_DEBUG(c,s) if (RtsFlags.DebugFlags.c) { s; }<u></u><u></u></p>
<p> ^<u></u><u></u></p>
<p>cc1.exe: all warnings being treated as errors<u></u><u></u></p>
<p>`gcc.exe' failed in phase `C Compiler'. (Exit code: 1)<u></u><u></u></p>
<p>rts/<a href="http://ghc.mk:255" target="_blank">ghc.mk:255</a>: recipe for target 'rts/dist/build/Linker.thr_debug_o' failed<u></u><u></u></p>
<p>make[1]: *** [rts/dist/build/Linker.thr_debug_o] Error 1<u></u><u></u></p>
<p>Makefile:129: recipe for target 'all' failed<u></u><u></u></p>
<p>make: *** [all] Error 2<u></u><u></u></p>
<p>/cygdrive/c/code/HEAD$ git log -2 rts/Linker.c <u></u><u></u></p>
<p>commit 01f449f4ffd2c4f23bfe5698b9f1b98a86276900<u></u><u></u></p>
<p>Author: Simon Marlow <<a href="mailto:marlowsd@gmail.com" target="_blank">marlowsd@gmail.com</a>><u></u><u></u></p>
<p>Date: Mon Jul 4 10:56:04 2016 +0100<u></u><u></u></p>
<p><u></u> <u></u></p>
<p> Fix 32-bit build failures<u></u><u></u></p>
<p><u></u> <u></u></p>
<p>commit 6377757918c1e7f63638d6f258cad8d5f02bb6a7<u></u><u></u></p>
<p>Author: Simon Marlow <<a href="mailto:marlowsd@gmail.com" target="_blank">marlowsd@gmail.com</a>><u></u><u></u></p>
<p>Date: Wed Jun 29 21:50:18 2016 +0100<u></u><u></u></p>
<p><u></u> <u></u></p>
<p> Linker: some extra debugging / logging<span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><u></u><u></u></span></p>
</div>
</div>
</blockquote></div><br></div></div>