<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 4 July 2016 at 09:45, Erik de Castro Lopo <span dir="ltr"><<a href="mailto:mle+hs@mega-nerd.com" target="_blank">mle+hs@mega-nerd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">Simon Marlow wrote:<br>
<br>
> I will fix it, sorry about this. Unfortunately I can't really add a<br>
> Windows validate into my workflow because it would mean rebooting my laptop<br>
> into Windows and not doing anything else for several hours.<br>
<br>
</span>Even building as 32 bit would have shaken out a bug in the format specifiers<br>
to the debugBelch statement.<br>
<br>
Are you on Linux? I use a 32 bit debian chroot on my otherwise 64 bit Debian<br>
system.<span class=""><br></span></blockquote><div><br></div><div>Building on 32-bit would flush out some bugs, but not others. Yes I could use a chroot, or a VM, and I could have Windows in a VM. But what about OS X? In fact validate on a single platform already ties up my machine for an hour, so the more platforms we have to validate the less practical it is to make small changes. I think more automation is the only good solution to this.<br><br></div><div>So, I rely on CI for most of my commits, whether it's Phabricator (now fixed!) or Travis.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
> We need some CI support for Windows - Ben/Austin any thoughts on this?<br>
<br>
</span>That would be an improvement, but it doesn't help for other OSes like Aix<br>
and Solaris or other CPUs.<br>
<br>
I also noticed that patch bypassed Phabricator. I assume that was a mistake. I've<br>
done it myself. We need to be particularly careful with the RTS code because<br>
its so fragile. It needs to be build and tested on a wide variety of systems.<span class=""><br></span></blockquote><div><br></div><div>It was actually intentional. The patch validated on Travis: <a href="https://travis-ci.org/simonmar/ghc/builds/141572355">https://travis-ci.org/simonmar/ghc/builds/141572355</a> and I didn't think it was worth having it reviewed (but if you want to review all linker patches I'd be happy to put them on Phabricator in the future).<br><br></div><div>Cheers<br></div><div>Simon<br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">
Erik<br>
--<br>
----------------------------------------------------------------------<br>
Erik de Castro Lopo<br>
<a href="http://www.mega-nerd.com/" rel="noreferrer" target="_blank">http://www.mega-nerd.com/</a><br>
</span><span class="">_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
</span><a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div><br></div></div>