<div dir="ltr">Austin: can you report this bug with the Phabricator people please.<div><br></div><div>For committers: don't use 'arc land' to land patches from others!</div><div><br></div><div>If this has happened to you in the past, could you please let me know. I am soon updating the contributors list on <a href="https://ghc.haskell.org/trac/ghc/wiki/TeamGHC">https://ghc.haskell.org/trac/ghc/wiki/TeamGHC</a>, and would like it to be complete. These are the patches that I'm aware of that were misattributed this year:</div><div><div><br></div><div>D600: Brian McKenna -> Erik de Castro Lopo</div>D971: Bernard Desmyter -> Thomas Miedema<br></div><div>D974: Zejun Wu -> Simon Marlow<br></div><div>#11209: John Paul Adrian Glaubitz -> Sergei Trofimovich</div><div><br></div><div>Thanks</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 29, 2014 at 8:21 AM, Joachim Breitner <span dir="ltr"><<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi,<br>
<br>
I was just about to apply a DR by David. First I ran<br>
$ arc patch D390<br>
which put me on a feature branch. Then I reworded the commit with<br>
$ git commit --amend<br>
and then I tried to land it with<br>
$ arc land<br>
Luckily I also passed --hold...<br>
<br>
It even asked me if I want to land the commit although I am not the<br>
author:<br>
<br>
This branch has revision 'D390: Reorder GHC.List; fix performance<br>
regressions' but you are not the author. Land this revision by dfeuer?<br>
[y/N] y<br>
<br>
But it still put me in the author field:<br>
<br>
$ git show HEAD<br>
commit a387c359b99667ce55016de3816b5d9873a155db<br>
Author: Joachim Breitner <<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a>><br>
Date: Wed Oct 29 08:17:05 2014 +0100<br>
<br>
Reorder GHC.List; fix performance regressions<br>
<br>
Summary:<br>
Rearrange some oddly placed code.<br>
<br>
(and undid my commit message changes....)<br>
<br>
Did I do something wrong?<br>
<br>
Anyways, it said something along the lines of<br>
Cleaning up feature branch...<br>
(Use `git checkout -b 'arcpatch-D390'<br>
'a3ceb0e7f44d53f728fb8bd0dfb4c97297818029'` if you want it<br>
back.)<br>
so with<br>
$ git commit --amend -C a3ceb0e7f44d53f728fb8bd0dfb4c97297818029<br>
I was able to get the edited commit message with the right author back.<br>
<br>
<br>
Greetings,<br>
Joachim<br>
<span><font color="#888888"><br>
--<br>
Joachim “nomeata” Breitner<br>
<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a> • <a href="http://www.joachim-breitner.de/" rel="noreferrer" target="_blank">http://www.joachim-breitner.de/</a><br>
Jabber: <a href="mailto:nomeata@joachim-breitner.de" target="_blank">nomeata@joachim-breitner.de</a> • GPG-Key: 0xF0FBF51F<br>
Debian Developer: <a href="mailto:nomeata@debian.org" target="_blank">nomeata@debian.org</a><br>
<br>
</font></span><br>_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://www.haskell.org/mailman/listinfo/ghc-devs</a><br>
<br></blockquote></div><br></div></div>