<div dir="ltr"><div>Simon,<br></div><div><br></div><div>your two most recent commits are not passing validate, see <a href="https://phabricator.haskell.org/diffusion/GHC/history" target="_blank">https://phabricator.haskell.org/diffusion/GHC/history</a></div><div><br></div><div>The first commit fails with a type error, though it seems you fixed this in the second commit.</div><div><br></div><div>The second commit fails with:</div><div><br>*** unexpected pass for T8968-3(normal)<br>*** unexpected pass for T8968-1(normal)<br></div><div><br></div><div><div>When master is not passing validate, patch submissions to Phabricator will not pass validate either.</div></div><div><br></div><div>When master is passing validate again, click 'Restart build' on the Phabricator Build you were investigating, and the results should be much clearer.</div><div><br></div><div>Thomas</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 6, 2015 at 12:22 PM, Simon Peyton Jones <span dir="ltr"><<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">| Indeed it appears that there is trouble on the `master` branch at the<br>
| moment. I'll be looking into this.<br>
<br>
I find it difficult to interpret Phab results. Eg<br>
<a href="https://phabricator.haskell.org/B5172" rel="noreferrer" target="_blank">https://phabricator.haskell.org/B5172</a><br>
says both "failed" and "passed".<br>
<br>
Also the build logs displayed eg here<br>
<a href="https://phabricator.haskell.org/harbormaster/build/5394/?l=0" rel="noreferrer" target="_blank">https://phabricator.haskell.org/harbormaster/build/5394/?l=0</a><br>
are truncated so you can't see what the exact failure was.<br>
<br>
But from the latter I'm guessing that the problem is:<br>
- I added a new warning<br>
- And I think validate uses -Wall and fails if any warning happens<br>
(which seems a bit brutal)<br>
<br>
The warnings are, I think legitimate. But I certainly don't want them to break the build. How to fix?<br>
* Remove -fwarn-all-missed-specialisations from -Wall.<br>
* Or add -fno-warn-all-missed-specialisations to validate<br>
<br>
I don't have a strong opinion. Can you do one or t'other?<br>
<br>
-fwarn-all-missed-specialisations says that there are overloaded functions being called without being specialised. That's quite interesting, and it's the kind of thing you'd like to see with "all warnings". But it's also perfectly reasonable to say "that's fine, I don't care that overloaded functions are being called".<br>
<br>
Are there any other warnings that -Wall does not include? That is, do we expect -Wall to mean "all" or just "nearly all"?<br>
<br>
I have no strong opinion.<br>
<br>
Apologies for causing this fuss.<br>
<br>
Simon<br>
<br>
| -----Original Message-----<br>
| From: <a href="mailto:noreply@phabricator.haskell.org" target="_blank">noreply@phabricator.haskell.org</a><br>
| [mailto:<a href="mailto:noreply@phabricator.haskell.org" target="_blank">noreply@phabricator.haskell.org</a>]<br>
| Sent: 06 August 2015 10:56<br>
| To: Simon Peyton Jones<br>
| Subject: [Differential] [Requested Changes To] D1133: Make derived<br>
| names deterministic<br>
|<br>
| bgamari requested changes to this revision.<br>
| bgamari added a comment.<br>
| This revision now requires changes to proceed.<br>
|<br>
| Indeed it appears that there is trouble on the `master` branch at the<br>
| moment. I'll be looking into this.<br>
|<br>
| The idea here looks reasonable, but what effect does this have on the<br>
| size of the build artifacts (e.g. object and interface files). It<br>
| seems like the names may grow substantially with this change. Could<br>
| you characterize this?<br>
|<br>
| Also, I would really like to see some haddocks on the top-level<br>
| bindings that are introduced here.<br>
|<br>
|<br>
| REPOSITORY<br>
| rGHC Glasgow Haskell Compiler<br>
|<br>
| REVISION DETAIL<br>
| <a href="https://phabricator.haskell.org/D1133" rel="noreferrer" target="_blank">https://phabricator.haskell.org/D1133</a><br>
|<br>
| EMAIL PREFERENCES<br>
| <a href="https://phabricator.haskell.org/settings/panel/emailpreferences/" rel="noreferrer" target="_blank">https://phabricator.haskell.org/settings/panel/emailpreferences/</a><br>
|<br>
| To: niteria, simonmar, simonpj, austin, bgamari<br>
| Cc: thomie<br>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs" rel="noreferrer" target="_blank">http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs</a><br>
</blockquote></div><br></div></div>