<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body><div><div style="font-family:Calibri,sans-serif;font-size:11pt">Hi<br><br>There is a sorta in limbo differential from gintas that would have solved this by doing it in the configure script. <br><br>I liked that solution. As far as I know the patch was delayed because the reviewers suggested we get rid of the perl dependency first.<br><br>Regards,<br>Tamar</div></div><div dir="ltr"><hr><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">From: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:thomasmiedema@gmail.com">Thomas Miedema</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Sent: </span><span style="font-family:Calibri,sans-serif;font-size:11pt">7/27/2015 10:41</span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">To: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:pali.gabor@gmail.com">Páli Gábor János</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Cc: </span><span style="font-family:Calibri,sans-serif;font-size:11pt"><a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a></span><br><span style="font-family:Calibri,sans-serif;font-size:11pt;font-weight:bold">Subject: </span><span style="font-family:Calibri,sans-serif;font-size:11pt">Re: Deleting sync-all</span><br><br></div></body></html><div dir="ltr">Hi <span style="font-size:12.8000001907349px">Gábor,</span><div><br></div><div>instead of changing `<a href="http://ghc.mk">ghc.mk</a>`, please change the builder script to also run `<span style="font-size:12.8000001907349px">git clone git://</span><a href="http://git.haskell.org/ghc-tarballs.git" rel="noreferrer" target="_blank" style="font-size:12.8000001907349px">git.haskell.org/ghc-tarballs.git</a><span style="font-size:12.8000001907349px">`.</span></div><div><br></div><div><div><span style="font-size:12.8000001907349px">(Edit: while typing this, I saw you just did so)</span></div></div><div><br></div><div><span style="font-size:12.8000001907349px">The benefits are:</span></div><div><span style="font-size:12.8000001907349px">* the windows specific part of creating a source distribution also gets tested</span></div><div><span style="font-size:12.8000001907349px">* the release manager can run </span><span style="font-size:12.8000001907349px">`make sdist` on any platform, and they'll get a complete source distribution they can upload</span></div><div><div><br></div></div><div>Thomas</div><div><br></div><div class="gmail_extra"><div class="gmail_quote">On Sun, Jul 26, 2015 at 8:36 PM, Páli Gábor János <span dir="ltr"><<a href="mailto:pali.gabor@gmail.com" target="_blank">pali.gabor@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Thomas,<br>
<br>
2015-07-21 12:45 GMT+02:00 Thomas Miedema <<a href="mailto:thomasmiedema@gmail.com">thomasmiedema@gmail.com</a>>:<br>
> To get the sources:<br>
><br>
> git clone --recursive git://<a href="http://git.haskell.org/ghc.git" rel="noreferrer" target="_blank">git.haskell.org/ghc.git</a><br>
> cd ghc<br>
> git clone git://<a href="http://git.haskell.org/ghc-tarballs.git" rel="noreferrer" target="_blank">git.haskell.org/ghc-tarballs.git</a> # Windows only<br>
<br>
Apparently, that last line is also needed even on non-Windows systems<br>
when one wants to make the "sdist" target, at least as I have observed<br>
on my builders, e.g. [1].<br>
<br>
So I have put together a small patch that aims to fix this -- mind<br>
you, I have not tested it on Windows, but theoretically it shall just<br>
work:<br>
<br>
--- a/<a href="http://ghc.mk" rel="noreferrer" target="_blank">ghc.mk</a><br>
+++ b/<a href="http://ghc.mk" rel="noreferrer" target="_blank">ghc.mk</a><br>
@@ -1183,9 +1183,14 @@ sdist-windows-tarballs: sdist-windows-tarballs-prep<br>
sdist-testsuite: sdist-testsuite-prep<br>
cd $(SRC_DIST_TESTSUITE_ROOT) && "$(TAR_CMD)" chf -<br>
$(SRC_DIST_BASE_NAME) 2> testsuite_log | $(TAR_COMP_CMD)<br>
-c > $(TOP)/$(SRC_DIST_TESTSUITE_TARBALL)<br>
<br>
+SDIST_TARGETS= sdist-ghc sdist-testsuite<br>
+<br>
+ifeq "$(Windows_Host)" "YES"<br>
+SDIST_TARGETS+= sdist-windows-tarballs<br>
+endif<br>
<br>
.PHONY: sdist<br>
-sdist : sdist-ghc sdist-windows-tarballs sdist-testsuite<br>
+sdist : $(SDIST_TARGETS)<br>
<br>
sdist-manifest : $(SRC_DIST_GHC_TARBALL)<br>
tar tjf $(SRC_DIST_GHC_TARBALL) | sed<br>
"s|^ghc-$(ProjectVersion)/||" | sort >sdist-manifest<br>
diff --git a/utils/haddock b/utils/haddock<br>
<br>
Are there any objections to commit this?<br>
<br>
Thanks,<br>
Gábor<br>
<br>
[1] <a href="http://haskell.inf.elte.hu/builders/freebsd-amd64-head/700/15.html" rel="noreferrer" target="_blank">http://haskell.inf.elte.hu/builders/freebsd-amd64-head/700/15.html</a><br>
</blockquote></div><br></div></div>