Reviews

Simon Peyton Jones simonpj at microsoft.com
Fri Jan 11 09:49:26 UTC 2019


So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F74%2Fdiffs%239f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853&data=02%7C01%7Csimonpj%40microsoft.com%7C728cbed6e44946c21bae08d6772e7477%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636827438744742026&sdata=eRJYkGGmP3rFPtxXGe3Lbe27YWeXnY9f1azHbtt0srw%3D&reserved=0>). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.

When I try that, it starts by displaying the code from the file.  No rotating circles or anything. But if I wait ten seconds, suddenly the comments appear.   So:

  *   rendering seems terribly slow
  *   there is no indication that it is incomplete

Maybe you just weren't waiting long enough?

Even displaying the original MR https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904 is slow. For 18 seconds it displays a kind of skeleton page with horizontal grey bars that flash occasionally.  Then it renders.

Simon

From: Richard Eisenberg <rae at cs.brynmawr.edu>
Sent: 10 January 2019 19:05
To: Ben Gamari <ben at smart-cactus.org>
Cc: Simon Peyton Jones <simonpj at microsoft.com>; Evan Laforge <qdunkan at gmail.com>; ghc-devs <ghc-devs at haskell.org>
Subject: Re: Reviews

While we're whinging:

- I'm looking at the Discussion page for an MR (https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F74%23note_1904&data=02%7C01%7Csimonpj%40microsoft.com%7C728cbed6e44946c21bae08d6772e7477%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636827438744742026&sdata=7l4qk3zTl4HuE0NvT2W8kWbIILmqXYZf0Wjj5KTq%2FzE%3D&reserved=0>) and I see a comment Simon made, beginning with "No, I am not!". I wanted a bit more context. So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F74%2Fdiffs%239f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853&data=02%7C01%7Csimonpj%40microsoft.com%7C728cbed6e44946c21bae08d6772e7477%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636827438744742026&sdata=eRJYkGGmP3rFPtxXGe3Lbe27YWeXnY9f1azHbtt0srw%3D&reserved=0>). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.

- Simon recently posted a bunch of comments in response to a bunch of my comments. I have a thick stack of emails about each individual comment. But when I view the discussion page (https://gitlab.haskell.org/ghc/ghc/merge_requests/74<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F74&data=02%7C01%7Csimonpj%40microsoft.com%7C728cbed6e44946c21bae08d6772e7477%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636827438744752067&sdata=1OoWI%2FzgymMOnP8FI9AX%2Btv09ErmsQA%2FEmVK6gccHm4%3D&reserved=0>), I can find Simon's comments only buried in the Discussions that I started. There appears to be no way to glean, from the web page, what has happened since last I looked. Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on. Now, the thick stack of emails seems like the only way to do this.

- Is there a way to get a timestamped list of what discussions are resolved? Sometimes it's nice to be able to check that the resolution was what I had hoped for.

- The Changes page has a table of contents on the left. This is useful sometimes. (In this way, GL beats Phab, where it was sometimes hard to find where a certain file is listed when in the middle of a review.) But is there a way to collapse the ToC? Most of the time, I'm focused on the code itself, and the ToC drastically reduces the number of characters per line, when I view diffs side-by-side.

Thanks!
Richard

PS: I well remember how phrustrated I was with Phab when that rolled out, and how I eventually came to appreciate it. I'm being more patient this time around. In retrospect my trouble was more with arcanist than with Phab itself. (Arcanist and I never really got along... we just reached an unsteady truce, and I won't miss it.) I am happy to be using git as the tool now. But it's effortful to figure out efficient workflows in a new space, and I'm grateful for any help here. Thanks.


On Jan 10, 2019, at 1:27 PM, Ben Gamari <ben at smart-cactus.org<mailto:ben at smart-cactus.org>> wrote:

Simon Peyton Jones <simonpj at microsoft.com<mailto:simonpj at microsoft.com>> writes:


|  Another issue is that apparently GitLab still sends one email per comment
|  instead of one comment per batch. This will evidently be fixed in GitLab
|  11.6 [1].

yes that is TERRIBLE.  When does 11.6 land?
It is the next release. I will poke our contact to make sure that they
realize the severity of the issue.


What I want is to have a batch of comments with an overview message.
We used that /all the time/ in Phab! For example:

  I like this patch but you might want to think about X and Y.
  Meanwhile I have added a bunch of detailed comments.

This would fit very well with the "batch of comments in one email" change.
Indeed and upstream agrees. They created a feature request [1] in response
to my suggestion. I'll make sure that I mention this to our GitLab contact.

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/9145<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fgitlab-org%2Fgitlab-ee%2Fissues%2F9145&data=02%7C01%7Csimonpj%40microsoft.com%7C728cbed6e44946c21bae08d6772e7477%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636827438744762041&sdata=hX4fjwdMRWF%2FnJew5St6WkB9lb77LmRxgUvvesbXy5k%3D&reserved=0>

_______________________________________________
ghc-devs mailing list
ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-devs/attachments/20190111/83dc99b6/attachment-0001.html>


More information about the ghc-devs mailing list