Gitlab pain

Evan Laforge qdunkan at gmail.com
Fri Jan 4 17:13:23 UTC 2019


The diff in https://gitlab.haskell.org/ghc/ghc/merge_requests/10/diffs
is the ground truth for the source code.  However, it's not ground
truth for comments.  You only get to see the ones attached to the
revisions selected in "Changes between x and y", which means they tend
to get lost.  The Discussion tab is ground truth for comments in that
you won't miss any if you look through it, but it gets cluttered.
There should be a "skip to first unresolved comment" button, which
helps.  I wish it let you cycle them instead of always going to the
first.  But the discussion tab is not good for seeing what the change
being discussed actually is, so you have to go back to Changes, at
which point you lose your place in Discussion.

If anyone knows a better way to do comments I'd also like to know... I
use gitlab at work and find it pretty awkward for medium-and-up sized
reviews.

On Sat, Jan 5, 2019 at 12:25 AM Richard Eisenberg <rae at cs.brynmawr.edu> wrote:
>
> GitLab groups posts on lines in MRs as "discussions". A discussion can be *resolved*. When it is resolved, the discussion is collapsed by default when you view the MR. The particular comment you're seeking can be found on the MR if you open the discussion you started at 10:04am this morning (GMT) and that Gabor closed at 2:10pm this afternoon. (I'm already missing comment numbers like in Trac.)
>
> I'm still learning my way around, too, so correct me (anyone) if there's a better way to describe all this.
>
> Richard
>
> On Jan 4, 2019, at 11:19 AM, Simon Peyton Jones via ghc-devs <ghc-devs at haskell.org> wrote:
>
> I’m getting lost in a maze of twisty little passages, all alike.
>
> I’m looking at
>
> https://gitlab.haskell.org/ghc/ghc/merge_requests/10#note_1877
>
> and
>
> https://gitlab.haskell.org/ghc/ghc/merge_requests/10
>
>
>
> But the note in the former starting “Another module should reference the symbol…” doesn’t show up in the latter, anywhere.
>
> How can I see the current state of play on this MR, the ground truth?
>
> Simon
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


More information about the ghc-devs mailing list