Always false stack checks are not eliminated - fix on the way

Simon Marlow marlowsd at gmail.com
Mon Oct 21 10:43:27 UTC 2013


On 17/10/2013 23:11, Jan Stolarek wrote:
> Hi guys,
>
> I accidentally introduced a bug in one of my recent commits (
> 94125c97e49987e91fa54da6c86bc6d17417f5cf): stack checks of the form
>
> if (Sp < SpLim) goto cUP; else goto cUQ;
>
> are not eliminated in the Cmm. I have a fix, but need to validate it and update the comments. It
> will be ready tomorrow.

Thanks for fixing this.  Would you mind also adding a test so that we 
notice if it gets broken in the future?  This would be a good test to 
put in codeGen/should_gen_asm.

Cheers,
Simon


More information about the ghc-devs mailing list