<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<h3 style="margin-top: 20px; margin-bottom: 10px;">
Marge Bot pushed to branch wip/marge_bot_batch_merge_job at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/020ad8d607279c9d0bfe58c4055d524b3a52e614">020ad8d6</a></strong>
<div>
<span> by Serge S. Gulin </span> <i> at 2024-10-29T16:16:50-04:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>JS: Re-add optimization for literal strings in genApp (fixes #23479)
Based on https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10588/
Co-authored-by: Sylvain Henry <sylvain@haskus.fr>
Co-authored-by: Andrei Borzenkov <root@sandwitch.dev>
Co-authored-by: Danil Berestov <goosedb@yandex.ru>
-------------------------
Metric Decrease:
T25046_perf_size_gzip
size_hello_artifact
size_hello_artifact_gzip
size_hello_unicode
size_hello_unicode_gzip
-------------------------
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/f75f7ff7f8e540ef426648768cb3f5e97e89f628">f75f7ff7</a></strong>
<div>
<span> by Cheng Shao </span> <i> at 2024-10-29T16:16:50-04:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>compiler: remove unused hscDecls/hscDeclsWithLocation
This patch removes unused `hscDecls`/`hscDeclsWithLocation` functions
from the compiler, to reduce maintenance burden when doing
refactorings related to ghci.
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/dd7b0f40c948aa8cee5e1eb34141bf12344e2d12">dd7b0f40</a></strong>
<div>
<span> by Cheng Shao </span> <i> at 2024-10-29T16:16:51-04:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>testsuite: add T25414 test case marked as broken
This commit adds T25414 test case to demonstrate #25414. It is marked
as broken and will be fixed by the next commit.
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/9d563c4969598d1630709d67bf3a1f01e645bb18">9d563c49</a></strong>
<div>
<span> by Cheng Shao </span> <i> at 2024-10-29T16:16:51-04:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>driver: fix foreign stub handling logic in hscParsedDecls
This patch fixes foreign stub handling logic in `hscParsedDecls`.
Previously foreign stubs were simply ignored here, so any feature that
involve foreign stubs would not work in ghci (e.g. CApiFFI). The patch
reuses `generateByteCode` logic and eliminates a large chunk of
duplicate logic that implements Core to bytecode generation pipeline
here. Fixes #25414.
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
30 changed files:
</h4>
<ul>
<li class="file-stats">
<a href="#0887cf39c5cdf9cf8d6758f410d7dab3023c0d77">
compiler/GHC/Builtin/Names.hs
</a>
</li>
<li class="file-stats">
<a href="#2e5692f568fd7b67a6b172e2a60469da8392508c">
compiler/GHC/Driver/Flags.hs
</a>
</li>
<li class="file-stats">
<a href="#9a679a2680ef6061397f1987091ea9f96ffe095d">
compiler/GHC/Driver/Main.hs
</a>
</li>
<li class="file-stats">
<a href="#774d88050336ef660c7a219fb06c480c2fc639bc">
compiler/GHC/Driver/Session.hs
</a>
</li>
<li class="file-stats">
<a href="#5aa3321b0f5c08d7ebfa1a4a3340d4451258988b">
compiler/GHC/Linker/Loader.hs
</a>
</li>
<li class="file-stats">
<a href="#2d8735ef84465467a5955da9f7cfe05d6aba0320">
compiler/GHC/StgToJS/Apply.hs
</a>
</li>
<li class="file-stats">
<a href="#452a7aecf67651b1b4584eef5b78fb73770785fd">
compiler/GHC/StgToJS/CodeGen.hs
</a>
</li>
<li class="file-stats">
<a href="#d8f42268b4be6e47d85a5c59c6797430b4672dc6">
compiler/GHC/StgToJS/Expr.hs
</a>
</li>
<li class="file-stats">
<a href="#97c256a2ec3c0a93d9cf5398d6496239520420a5">
compiler/GHC/StgToJS/ExprCtx.hs
</a>
</li>
<li class="file-stats">
<a href="#7cf4e8c9485c255dc72f13e75192bfa3cf66eef3">
compiler/GHC/StgToJS/Linker/Linker.hs
</a>
</li>
<li class="file-stats">
<a href="#6dd3fa55cb98ddb1f4a63768d5cc31943668cae5">
compiler/GHC/StgToJS/Literal.hs
</a>
</li>
<li class="file-stats">
<a href="#825bfd76a2d23ac65ca409854eb43db6d9895462">
compiler/GHC/StgToJS/Monad.hs
</a>
</li>
<li class="file-stats">
<a href="#2cb44586e641223767ea8142d095290747302b50">
<span class="new-file">
+
compiler/GHC/StgToJS/Sinker/Collect.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#24d56a77d3aac2f92396c296bf07c33280331b8c">
compiler/GHC/StgToJS/Sinker.hs
→
compiler/GHC/StgToJS/Sinker/Sinker.hs
</a>
</li>
<li class="file-stats">
<a href="#d35978c9cba2d29a2f96ce2e70fb795fe37657e0">
<span class="new-file">
+
compiler/GHC/StgToJS/Sinker/StringsUnfloat.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#c4f2ab093ca8384cdc23b852f44c6ef45c0c28e0">
compiler/GHC/StgToJS/Symbols.hs
</a>
</li>
<li class="file-stats">
<a href="#b6a01b4f7692cceb21d8c5c217c1303c78e154e5">
compiler/GHC/StgToJS/Types.hs
</a>
</li>
<li class="file-stats">
<a href="#27aadaecb86e6f3f545286614804ef107a9949c8">
compiler/GHC/Types/ForeignCall.hs
</a>
</li>
<li class="file-stats">
<a href="#0f33fd88c617246c7f89c4477d2d1d24f942df23">
compiler/ghc.cabal.in
</a>
</li>
<li class="file-stats">
<a href="#36435f993774454b5956f3a38a9276ed176c61cc">
docs/users_guide/debugging.rst
</a>
</li>
<li class="file-stats">
<a href="#a0dea8eb08fb24020cddb6dba0446f0ff6dd5ef5">
rts/js/string.js
</a>
</li>
<li class="file-stats">
<a href="#cec777b2bce8318e43fbf16b998e094e108cf756">
<span class="new-file">
+
testsuite/tests/ghci/scripts/T25414.script
</span>
</a>
</li>
<li class="file-stats">
<a href="#080fb38cc741d3f1a476696b3373ab7cf48c2aaa">
testsuite/tests/ghci/scripts/all.T
</a>
</li>
<li class="file-stats">
<a href="#2c4dbe4df467aeeabfb975609094cd046283a4f7">
testsuite/tests/javascript/Makefile
</a>
</li>
<li class="file-stats">
<a href="#0bc6bbc316c80b513d8f5e0f4f73ed0b838d2d75">
<span class="new-file">
+
testsuite/tests/javascript/T23479_1.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#318f2cd8c097d0bec5b6a65e8520d8c7b42d43af">
<span class="new-file">
+
testsuite/tests/javascript/T23479_1.stdout
</span>
</a>
</li>
<li class="file-stats">
<a href="#0ab3f89d526b2f07d97f73fbef7261e2f84bd8e8">
<span class="new-file">
+
testsuite/tests/javascript/T23479_2.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#3e8456639eff92c8b7405e33f53f945e9abd6d6a">
<span class="new-file">
+
testsuite/tests/javascript/T23479_2.stdout
</span>
</a>
</li>
<li class="file-stats">
<a href="#4645eb425d61c372e866adad12925b640d41a1a8">
testsuite/tests/javascript/T24495.hs
</a>
</li>
<li class="file-stats">
<a href="#e8908136884c0e7667fa501fdb5f3c48a5c07668">
testsuite/tests/javascript/T24495.stdout
</a>
</li>
</ul>
<h5 style="margin-top: 10px; margin-bottom: 10px; font-size: .875rem;">
The diff was not included because it is too large.
</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/-/compare/d5e7990ca9637ebee2293b22815fa0c393231baf...9d563c4969598d1630709d67bf3a1f01e645bb18">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.haskell.org">gitlab.haskell.org</a>. <a href="https://gitlab.haskell.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.haskell.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
</p>
</div>
</body>
</html>