<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,.01) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<h3 style="margin-top: 20px; margin-bottom: 10px;">
Rodrigo Mesquita pushed to branch wip/romes/exceptions-propagate at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/9e0cebe8cc6a5dc335f23b5cd6cab1baf3d470c3">9e0cebe8</a></strong>
<div>
<span> by Rodrigo Mesquita </span> <i> at 2024-10-01T16:05:02+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>Remove redundant CallStack from exceptions
Before the exception backtraces proposal was implemented, ErrorCall
accumulated its own callstack via HasCallStack constraints, but
ExceptionContext is now accumulated automatically.
The original ErrorCall mechanism is now redundant and we get a duplicate
CallStack
CLC proposal#285
Fixes #25283
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/cc61ea80f439f45334eebe9207f302af90a0396f">cc61ea80</a></strong>
<div>
<span> by Rodrigo Mesquita </span> <i> at 2024-10-01T16:13:12+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>Freeze call stack in error throwing functions
CLC proposal#285
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/6219a5b15ee49f50a7c1ecd77b2829e387de33c5">6219a5b1</a></strong>
<div>
<span> by Rodrigo Mesquita </span> <i> at 2024-10-01T16:13:19+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>De-duplicate displayContext and displayExceptionContext
The former was unused except for one module where it was essentially
re-defining displayExceptionContext.
Moreover, this commit extends the fix from
bfe600f5bb3ecd2c8fa71c536c63d3c46984e3f8 to displayExceptionContext too,
which was missing.
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/39e913453a10389d690255b8ab6e90e4ddcdbb66">39e91345</a></strong>
<div>
<span> by Rodrigo Mesquita </span> <i> at 2024-10-01T16:13:19+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>Re-export NoBacktrace from Control.Exception
This was originally proposed and accepted in section
"2.7 Capturing Backtraces on Exceptions"
of the CLC proposal for exception backtraces.
However, the implementation missed this re-export, which this commit now
fixes.
</pre>
</li>
<li>
<strong style="font-weight: 600;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/1186c66cbef853505c0033534dbb4177d9c2d5e1">1186c66c</a></strong>
<div>
<span> by Rodrigo Mesquita </span> <i> at 2024-10-01T16:13:20+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 14px; color: #28272d; position: relative; font-family: "GitLab Mono","JetBrains Mono","Menlo","DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>Fix exception backtraces from GHCi
When running the program with `runhaskell`/`runghc` the backtrace should
match the backtrace one would get by compiling and running the program.
But currently, an exception thrown in a program interpreted with
`runhaskell` will:
* Not include the original exception backtrace at all
* Include the backtrace from the internal GHCi/ghc rethrowing of the
original exception
This commit fixes this divergence by not annotating the ghc(i) backtrace
(with NoBacktrace) and making sure that the backtrace of the original
exception is serialized across the boundary and rethrown with the
appropriate context.
Fixes #25116
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
30 changed files:
</h4>
<ul>
<li class="file-stats">
<a href="#24c58f4447a259104c534fcb40cce7e31fb8df08">
compiler/GHC/Utils/Panic/Plain.hs
</a>
</li>
<li class="file-stats">
<a href="#57d22eb49f269b51f07e23c509834d85e25f691e">
ghc/GHCi/UI/Monad.hs
</a>
</li>
<li class="file-stats">
<a href="#d1f7a79361ae6cdc4939449936139b5703ca4c3d">
libraries/base/src/Control/Exception.hs
</a>
</li>
<li class="file-stats">
<a href="#4e178ecdf45714edd8cff9e89da07ead424c958d">
libraries/base/src/GHC/Exception.hs
</a>
</li>
<li class="file-stats">
<a href="#db05270d6e4557a98dedc09369c652f3a903aa64">
libraries/base/src/GHC/Stack.hs
</a>
</li>
<li class="file-stats">
<a href="#6006e1ae32823cb3154ac0b6ac4db1557c24448f">
libraries/base/tests/IO/T4808.stderr
</a>
</li>
<li class="file-stats">
<a href="#e568ef08382fdbbe133494fb14a9e6d96000c96b">
libraries/base/tests/IO/mkdirExists.stderr
</a>
</li>
<li class="file-stats">
<a href="#db536dd42d23af99a81aac016d61b71f80f8f4ea">
libraries/base/tests/IO/openFile002.stderr
</a>
</li>
<li class="file-stats">
<a href="#fb6c1c19fc7bb6f4f5ba85e8b9f006477ba0bd9f">
libraries/base/tests/IO/withBinaryFile001.stderr
</a>
</li>
<li class="file-stats">
<a href="#b7064d6743bd22d40dbeabdd98ee51a82fd883c8">
libraries/base/tests/IO/withFile001.stderr
</a>
</li>
<li class="file-stats">
<a href="#7d385ab1064e418a0b4159db1082b481b60f6fab">
libraries/base/tests/IO/withFileBlocking001.stderr
</a>
</li>
<li class="file-stats">
<a href="#582dfe030c20c9a85f522b3b4fa585d2cbe4e07d">
libraries/base/tests/T15349.stderr
</a>
</li>
<li class="file-stats">
<a href="#839c13786b361f4dc01e52a7ac079c768f8e3ae3">
libraries/base/tests/T19288.stderr
</a>
</li>
<li class="file-stats">
<a href="#dad99a46ecedc43a3b72908bfffdac8a3ff256d5">
libraries/base/tests/T24807.stderr
</a>
</li>
<li class="file-stats">
<a href="#b817c80cbb15890d9a6df41e91d15d7442471f3c">
libraries/base/tests/all.T
</a>
</li>
<li class="file-stats">
<a href="#221c6623fbe167ed66be532811b5901dc4182a3a">
libraries/base/tests/assert.stderr
</a>
</li>
<li class="file-stats">
<a href="#55f2acbca5ea131272343057079bac4dbeda13fa">
<span class="deleted-file">
−
libraries/base/tests/topHandler04.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#43a92b432921c3df697ef5b674fc72c825518b06">
<span class="deleted-file">
−
libraries/base/tests/topHandler04.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#af30c6b99312124f2098e256a7a9eb43d6d40011">
libraries/ghc-internal/src/GHC/Internal/Exception.hs
</a>
</li>
<li class="file-stats">
<a href="#6c930f1408a93a41428984b9467644fb971deb44">
libraries/ghc-internal/src/GHC/Internal/Exception/Context.hs
</a>
</li>
<li class="file-stats">
<a href="#03cfee2d5ff1e2f3ab92a8cb79be769da8656d93">
libraries/ghc-internal/src/GHC/Internal/Exception/Type.hs
</a>
</li>
<li class="file-stats">
<a href="#bb83cf49f08e4c2ec66274e8426fb1ffc5f604c2">
libraries/ghc-internal/src/GHC/Internal/IO.hs
</a>
</li>
<li class="file-stats">
<a href="#58c67851d6e1f050ad5572c08d9064b15eb2fd95">
libraries/ghc-internal/src/GHC/Internal/IO/Exception.hs
</a>
</li>
<li class="file-stats">
<a href="#e1b09d31cc7152806d73dac009af231b5664d1ba">
libraries/ghc-internal/src/GHC/Internal/Stack.hs
</a>
</li>
<li class="file-stats">
<a href="#2d5db73b257ef13fb6f2fd73fcb533c218e1c87d">
libraries/ghc-internal/src/GHC/Internal/Stack.hs-boot
</a>
</li>
<li class="file-stats">
<a href="#d05e96a989f70e134d386fee7c8b523ec2bc88c7">
<span class="deleted-file">
−
libraries/ghc-internal/src/GHC/Internal/Stack/CCS.hs-boot
</span>
</a>
</li>
<li class="file-stats">
<a href="#ed5b77135b8d6077d6f77541d166d7b8fe93f9de">
libraries/ghci/GHCi/Message.hs
</a>
</li>
<li class="file-stats">
<a href="#fdd34ceb84d7b95dccbd9172ce507eaea9b5abd4">
libraries/ghci/GHCi/Run.hs
</a>
</li>
<li class="file-stats">
<a href="#e4ed1b2f2abaedbc822218e069c87d9ac130e215">
testsuite/tests/annotations/should_fail/annfail12.stderr
</a>
</li>
<li class="file-stats">
<a href="#fb0c13d4f609903a43ce2268d21b37131bfd60e7">
testsuite/tests/arityanal/should_run/T21694a.stderr
</a>
</li>
</ul>
<h5 style="margin-top: 10px; margin-bottom: 10px; font-size: .875rem;">
The diff was not included because it is too large.
</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/-/compare/571aa8f3433cbc59cd43c4d9d072c1b9a6182e6b...1186c66cbef853505c0033534dbb4177d9c2d5e1">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.haskell.org">gitlab.haskell.org</a>. <a href="https://gitlab.haskell.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.haskell.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
</p>
</div>
</body>
</html>