<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en" style='--code-editor-font: var(--default-mono-font, "Menlo"), DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace;'>
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style data-premailer="ignore" type="text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: 0.875rem;
}
body {
-webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px;
}
body {
font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size: inherit;
}
</style>
</head>
<body style='font-size: inherit; -webkit-text-shadow: rgba(255,255,255,0.01) 0 0 1px; font-family: var(--default-regular-font, -apple-system),BlinkMacSystemFont,"Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji";'>
<div class="content">
<h3 style="margin-top: 20px; margin-bottom: 10px;">
Matthew Pickering pushed to branch wip/t22884 at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
Commits:
</h4>
<ul>
<li>
<strong style="font-weight: bold;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/fa26afc09efdf0ebae0ebac105fe15d99a241cfa">fa26afc0</a></strong>
<div>
<span> by Matthew Pickering </span> <i> at 2023-05-11T07:14:07+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>Allow API users to wrap error messages created during 'load'
This allows API users to configure how messages are rendered when they
are emitted from the load function. For an example see how
'loadWithCache' is used in GHCi.
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/d68100b847720cbfe0e8923681862373857f63fc">d68100b8</a></strong>
<div>
<span> by Matthew Pickering </span> <i> at 2023-05-11T07:14:07+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>Abstract cantFindError and turn Opt_BuildingCabal into a print-time option
* cantFindError is abstracted so that the parts which mention specific
things about ghc/ghci are parameters. The intention being that
GHC/GHCi can specify the right values to put here but otherwise
display the same error message.
* The BuildingCabalPackage argument from GenericMissing is removed and
turned into a print-time option. The reason for the error is not
dependent on whether `-fbuilding-cabal-package` is passed, so we don't
want to store that in the error message.
</pre>
</li>
<li>
<strong style="font-weight: bold;"><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/8d3c21ae621af3ac7bfbf79fc25d0044e8c8d6b5">8d3c21ae</a></strong>
<div>
<span> by Matthew Pickering </span> <i> at 2023-05-11T07:14:07+01:00 </i>
</div>
<pre class="commit-message" style='white-space: pre-wrap; display: block; font-size: 0.875rem; color: #333238; position: relative; font-family: var(--default-mono-font, "Menlo"),"DejaVu Sans Mono","Liberation Mono","Consolas","Ubuntu Mono","Courier New","andale mono","lucida console",monospace; word-break: break-all; word-wrap: break-word; background-color: #fbfafd; border-radius: 2px; margin: 0; padding: 8px 12px; border: 1px solid #dcdcde;'>error messages: Don't display ghci specific hints for missing packages
Tickets like #22884 suggest that it is confusing that GHC used on the
command line can suggest options which only work in GHCi.
This ticket uses the error message infrastructure to override certain
error messages which displayed GHCi specific information so that this
information is only showed when using GHCi.
The main annoyance is that we mostly want to display errors in the same
way as before, but with some additional information. This means that the
error rendering code has to be exported from the Iface/Errors/Ppr.hs
module.
I am unsure about whether the approach taken here is the best or most
maintainable solution.
Fixes #22884
</pre>
</li>
</ul>
<h4 style="margin-top: 10px; margin-bottom: 10px;">
30 changed files:
</h4>
<ul>
<li class="file-stats">
<a href="#dbce6cb5e8f3d5287103c66d1a56ad63bbbd11a9">
compiler/GHC/Driver/Backpack.hs
</a>
</li>
<li class="file-stats">
<a href="#c786816bca5e182a02da23ebd34ff8563b35e55a">
compiler/GHC/Driver/Config/Diagnostic.hs
</a>
</li>
<li class="file-stats">
<a href="#1dab250036d04cfcf3530f6ff27889f723cc2dda">
compiler/GHC/Driver/Make.hs
</a>
</li>
<li class="file-stats">
<a href="#05179f6a260af85dabe0cfb5ed2204da64dadd33">
compiler/GHC/Iface/Errors.hs
</a>
</li>
<li class="file-stats">
<a href="#cd077d8c3df481acea295841f9a5bba46e555fe4">
compiler/GHC/Iface/Errors/Ppr.hs
</a>
</li>
<li class="file-stats">
<a href="#b5a1d947a78cef8abda1814a89dc7a5e5d31f3fb">
compiler/GHC/Iface/Errors/Types.hs
</a>
</li>
<li class="file-stats">
<a href="#1dd9c7a6bbc222c976a6ec1c4b772232ae60f7e5">
compiler/GHC/Tc/Errors/Ppr.hs
</a>
</li>
<li class="file-stats">
<a href="#56cab10ba9d31c526f47a492a4151a878077dc2d">
docs/users_guide/9.8.1-notes.rst
</a>
</li>
<li class="file-stats">
<a href="#c30f4ac98f08779ad1bd5a02a27802862c1e9521">
ghc/GHCi/UI.hs
</a>
</li>
<li class="file-stats">
<a href="#f6005a8cb6f21858ca5d639339a46fa7b1695e41">
ghc/GHCi/UI/Exception.hs
</a>
</li>
<li class="file-stats">
<a href="#86ce933fadefa3e14dd5e5fa11bb489ebfdda66e">
testsuite/tests/driver/multipleHomeUnits/multipleHomeUnitsModuleVisibility.stderr
</a>
</li>
<li class="file-stats">
<a href="#a295d50cfdd801fb254296216db36aaf6871c90d">
testsuite/tests/ghc-api/target-contents/TargetContents.stderr
</a>
</li>
<li class="file-stats">
<a href="#0257b0d6aa8b503f5021e71ec3b206f9efa00eaa">
testsuite/tests/ghc-e/should_run/T2636.stderr
</a>
</li>
<li class="file-stats">
<a href="#8530ef7dd77ec159918938942ff07122e65e8e5e">
testsuite/tests/module/mod1.stderr
</a>
</li>
<li class="file-stats">
<a href="#8255f4ab1d81dac78f24a48f7f15dad3b0683ef0">
testsuite/tests/module/mod2.stderr
</a>
</li>
<li class="file-stats">
<a href="#5972bbb6a0a18aebe9feabe6ddc1f6eea2b7f89a">
<span class="new-file">
+
testsuite/tests/package/T22884.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#9eaf3f966817191d6449df76bb2bc4da5bebceeb">
<span class="new-file">
+
testsuite/tests/package/T22884.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#0387d4c2483acee620a9f1aa31a100e2a925bf78">
<span class="new-file">
+
testsuite/tests/package/T22884_interactive.script
</span>
</a>
</li>
<li class="file-stats">
<a href="#b97e1e4429aedb1dbb093766d7d7fe0d80ab32ac">
<span class="new-file">
+
testsuite/tests/package/T22884_interactive.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#1e49e6d9e642a50f7526ec553e55c65457000446">
testsuite/tests/package/T4806.stderr
</a>
</li>
<li class="file-stats">
<a href="#54926762c80b77fa971ee6bef2eff94fa04f0342">
<span class="new-file">
+
testsuite/tests/package/T4806_interactive.script
</span>
</a>
</li>
<li class="file-stats">
<a href="#1ee6c36856cc8bc93b18475e49ebbafae1995d3a">
<span class="new-file">
+
testsuite/tests/package/T4806_interactive.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#e1274c8147299433da67ded3f41712f15ac9195c">
testsuite/tests/package/T4806a.stderr
</a>
</li>
<li class="file-stats">
<a href="#f5ce67b4b47ee192c185f839e767e8de4cfd61da">
testsuite/tests/package/all.T
</a>
</li>
<li class="file-stats">
<a href="#bdb91f6f4c4417e5a8a84b0dceb7b25467a0fa59">
testsuite/tests/package/package01e.stderr
</a>
</li>
<li class="file-stats">
<a href="#8aa7ba79ba02c571af324db858852a4d37bde185">
testsuite/tests/package/package06e.stderr
</a>
</li>
<li class="file-stats">
<a href="#37c630d32bbca9792ab42f083eed626c0be9f399">
testsuite/tests/package/package07e.stderr
</a>
</li>
<li class="file-stats">
<a href="#500a4a0daa03ca5a101c0c0efae578582e818f65">
testsuite/tests/package/package08e.stderr
</a>
</li>
<li class="file-stats">
<a href="#daf39fc81f84da805ed93608264d0180a88012fe">
testsuite/tests/perf/compiler/parsing001.stderr
</a>
</li>
<li class="file-stats">
<a href="#d3c376ac9f2bfe2db2cfbe25dd25fad85f750c67">
testsuite/tests/plugins/T11244.stderr
</a>
</li>
</ul>
<h5 style="margin-top: 10px; margin-bottom: 10px; font-size: 0.875rem;">
The diff was not included because it is too large.
</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #737278;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/-/compare/3635f32fe170a3b4a85d10ba56d576f9bea16df0...8d3c21ae621af3ac7bfbf79fc25d0044e8c8d6b5">View it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target="_blank" rel="noopener noreferrer" href="https://gitlab.haskell.org">gitlab.haskell.org</a>. <a href="https://gitlab.haskell.org/-/profile/notifications" target="_blank" rel="noopener noreferrer" class="mng-notif-link">Manage all notifications</a> · <a href="https://gitlab.haskell.org/help" target="_blank" rel="noopener noreferrer" class="help-link">Help</a>
</p>
</div>
</body>
</html>