<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
John Ericson pushed to branch wip/primop-naming-consistency
at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/3d9b490fd27e645fd839eeb2316d36bf076d4479">3d9b490f</a></strong>
<div>
<span>by John Ericson</span>
<i>at 2020-11-25T23:07:32+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Cleanup some primop constructor names
Harmonize the internal (big sum type) names of the native vs fixed-sized
number primops a bit. (Mainly by renaming the former.)
No user-facing names are changed.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/f0a3896b9a845bf00283eb8c961bdb0c96c80f86">f0a3896b</a></strong>
<div>
<span>by John Ericson</span>
<i>at 2020-11-25T23:09:45+00:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Cleanup number primop conversion names
Don't use "extend" or "narrow" in some of the user-facing primops
names for conversions.
- Names like `narrowInt32#` are misleading when `Int` is 32-bits.
- Names like `extendInt64#` are flat-out wrong when `Int is
32-bits.
- `narrow{Int,Word}<N>#` however map a type to itself, and so don't
suffer from this problem. They are left as-is.
</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#451725cc4e5d443a3b7c2adcdf224840f953b7e2">
compiler/GHC/Builtin/primops.txt.pp
</a>
</li>
<li class="file-stats">
<a href="#1684e8db5c0d415248dabe224ffe70205adc6b0f">
compiler/GHC/CmmToAsm/Ppr.hs
</a>
</li>
<li class="file-stats">
<a href="#aa79261abf782f3dc603af7fbd5c4b08ed3ddb88">
compiler/GHC/Core/Opt/ConstantFold.hs
</a>
</li>
<li class="file-stats">
<a href="#d12a108e34fe83acc9c99357ae841e22a0af0a23">
compiler/GHC/StgToCmm/Prim.hs
</a>
</li>
<li class="file-stats">
<a href="#3aa56839e36b2219f9ad54f5646ef3005da9c672">
compiler/GHC/Tc/Deriv/Generate.hs
</a>
</li>
<li class="file-stats">
<a href="#4569c39c0942a37f3d3a5b5014fcc735d38b82e8">
libraries/base/GHC/IO/Encoding/CodePage.hs
</a>
</li>
<li class="file-stats">
<a href="#82edd023ef48250fe07a75b9fabfc3fbe587327c">
libraries/base/GHC/IO/Encoding/UTF16.hs
</a>
</li>
<li class="file-stats">
<a href="#b407b9e9712a271c5d51599c018f7f94338f333b">
libraries/base/GHC/IO/Encoding/UTF32.hs
</a>
</li>
<li class="file-stats">
<a href="#5297aa37d3ef9f9dbb868b6bd960139d29f2e289">
libraries/base/GHC/IO/Encoding/UTF8.hs
</a>
</li>
<li class="file-stats">
<a href="#10be392b7f7b391a804a9d9e07af9686755ee4c7">
libraries/base/GHC/Int.hs
</a>
</li>
<li class="file-stats">
<a href="#209179850d5b5187e3d75f1c4403ec35838a78e8">
libraries/base/GHC/Storable.hs
</a>
</li>
<li class="file-stats">
<a href="#b2790eba050766b3c5aefa4efc5ed45ca998764b">
libraries/base/GHC/Word.hs
</a>
</li>
<li class="file-stats">
<a href="#80368e1dda3b1b395de1091bec3a68c7e717ff49">
libraries/ghci/GHCi/BreakArray.hs
</a>
</li>
<li class="file-stats">
<a href="#8410ee7d61c1091fb0585afc7b6cc587c7cde3f3">
testsuite/tests/array/should_run/arr020.hs
</a>
</li>
<li class="file-stats">
<a href="#1151246975a0da91164d6ff94c3a050693029d67">
testsuite/tests/cmm/opt/T18141.hs
</a>
</li>
<li class="file-stats">
<a href="#6acf043a97aa875c79874ffd6c4cb7851c389be1">
testsuite/tests/codeGen/should_compile/T18614.hs
</a>
</li>
<li class="file-stats">
<a href="#807eaf9475ab7cbb2f3bdb56950ac7cb6d7abf49">
testsuite/tests/codeGen/should_run/cgrun070.hs
</a>
</li>
<li class="file-stats">
<a href="#1edd30209f15a090b0f6480eb2decb424e7ec40b">
testsuite/tests/codeGen/should_run/cgrun072.hs
</a>
</li>
<li class="file-stats">
<a href="#438c56e460d2164162d7707416f9a47b402e600e">
testsuite/tests/codeGen/should_run/cgrun075.hs
</a>
</li>
<li class="file-stats">
<a href="#27a4b38ed2f0cacf1d46cd0674b3d92e17d0f9c3">
testsuite/tests/codeGen/should_run/cgrun076.hs
</a>
</li>
<li class="file-stats">
<a href="#f5e48ab8b55c383c09729a2bc80ce12a9b619889">
testsuite/tests/codeGen/should_run/compareByteArrays.hs
</a>
</li>
<li class="file-stats">
<a href="#b0ee0e1ea730943b6b52774c1d7c041d7fde5b0a">
testsuite/tests/ffi/should_run/PrimFFIInt16.hs
</a>
</li>
<li class="file-stats">
<a href="#7bc7c7af9598ab2b9ede83db05147b81f964f51a">
testsuite/tests/ffi/should_run/PrimFFIInt8.hs
</a>
</li>
<li class="file-stats">
<a href="#487e629ea6575d15e971a8a02485cd5647c53a78">
testsuite/tests/ffi/should_run/PrimFFIWord16.hs
</a>
</li>
<li class="file-stats">
<a href="#f25cdedb4a0f1872b5ba6323ca2e4bf3efd3424b">
testsuite/tests/ffi/should_run/PrimFFIWord8.hs
</a>
</li>
<li class="file-stats">
<a href="#ac5631f34010f408a6ba390a97385726d3e1bf0e">
testsuite/tests/ffi/should_run/T16650a.hs
</a>
</li>
<li class="file-stats">
<a href="#15e06e98c80167eeb2f4865df32f52f8dd4a027a">
testsuite/tests/ffi/should_run/T16650b.hs
</a>
</li>
<li class="file-stats">
<a href="#5050ab0dc60c7a131c973af853bb7671d04991dd">
testsuite/tests/ffi/should_run/UnliftedNewtypesByteArrayOffset.hs
</a>
</li>
<li class="file-stats">
<a href="#1448a7e9540f6d7f2dfdb8b7ca6f1cc848358df5">
testsuite/tests/lib/integer/integerImportExport.hs
</a>
</li>
<li class="file-stats">
<a href="#a3f0c42c513830f3bd1f5243034c7ea4f0861fe4">
testsuite/tests/numeric/should_compile/T16402.stderr-ws-32
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #666;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/-/compare/cd935e98c4297aa1fd14b057df381c28dcac90e2...f0a3896b9a845bf00283eb8c961bdb0c96c80f86">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.haskell.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>