<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Sebastian Graf pushed to branch wip/T18341
at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/b5a6da4b59318107db0c24224bf7963bc87d02cf">b5a6da4b</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:37:15+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">PmCheck: Big refactor using guard tree variants more closely following source syntax (#18565)
Previously, we desugared and coverage checked plain guard trees as
described in Lower Your Guards. That caused (in !3849) quite a bit of
pain when we need to partially recover tree structure of the input
syntax to return covered sets for long-distance information, for
example.
In this refactor, I introduced a guard tree variant for each relevant
source syntax component of a pattern-match (mainly match groups, match,
GRHS, empty case, pattern binding). I made sure to share as much
coverage checking code as possible, so that the syntax-specific checking
functions are just wrappers around the more substantial checking
functions for the LYG primitives (`checkSequence`, `checkGrds`).
The refactoring payed off in clearer code and elimination of all panics
related to assumed guard tree structure and thus fixes #18565.
I also took the liberty to rename and re-arrange the order of functions
and comments in the module, deleted some dead and irrelevant Notes,
wrote some new ones and gave an overview module haddock.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/1ac60f6033d24395a8be54c85bbce1f87fc80ccd">1ac60f60</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix #18341
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/fb066ef418b194adc97d8be9353eeb59f57fc667">fb066ef4</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Make PmConCt lazy and preserve ⊥
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/8ed86d048d0f6284b9dc5d11d63cf13d02bc80c4">8ed86d04</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix a few bugs
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/ddb5179618035121a23649ed87ed175d1439c268">ddb51796</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Accept tests
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/33c7c4f9cfde3ab0d09bf221b174b776f7bf9ed4">33c7c4f9</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add regression test for #18341
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/27cb92d0b03f8ea59bdb27fa7f034a380e7305a0">27cb92d0</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add regression test for #17725
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/95db9b7ee63cb4b6c406835f10db2bac29a167ac">95db9b7e</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add regression test for #17378
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/1c88a1385eb64ef4479f5059d41aa962b690333d">1c88a138</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add regression test for #10183
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/1f6c6c17b4298ed83948ba486a5bcc87cf84afe3">1f6c6c17</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add regression test for #17729
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/9a5e46537bb16e1783f0981641ea1d6e086ae487">9a5e4653</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Add regression test for fixed #18273
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/e55a62ddf8abb008911c1e51029507b7843d75ff">e55a62dd</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:41:58+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor ensureInhabited and resolve a scoping bug from the previous refactor
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/40c39c8f25a4b45d8c56572d586ddf5ded859288">40c39c8f</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T11:56:39+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">review feedback
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/67f24014f21773731f8590d91237dc0eed728bb9">67f24014</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T12:21:50+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Rename Delta to Nabla
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/44eeaa086cadda374f0d4c17e2a0e974118abb62">44eeaa08</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T13:28:17+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">A bit of cleanup
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/5390abaafec8bb8328f3db96aa322da505c980fa">5390abaa</a></strong>
<div>
<span>by Sebastian Graf</span>
<i>at 2020-08-28T15:00:35+02:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Accept the change to T17340
</pre>
</li>
</ul>
<h4>10 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#a5cc2925ca8258af241be7e5b0381edf30266302">
.gitignore
</a>
</li>
<li class="file-stats">
<a href="#6fcf64907fb5bdd93082d2d1eb94e4566e735865">
compiler/GHC/Core/DataCon.hs
</a>
</li>
<li class="file-stats">
<a href="#2fefe3125c649bc5377b06a7cca18e785855b79c">
compiler/GHC/Data/Bag.hs
</a>
</li>
<li class="file-stats">
<a href="#29399f07d3320158454cb214d24b4825a7bf4928">
compiler/GHC/Data/OrdList.hs
</a>
</li>
<li class="file-stats">
<a href="#65e2067fbb7377818b6cadff0531f44029499948">
compiler/GHC/HsToCore/Binds.hs
</a>
</li>
<li class="file-stats">
<a href="#6bdd5abc649727f2a802bc96ce5c276de19d3726">
compiler/GHC/HsToCore/Expr.hs
</a>
</li>
<li class="file-stats">
<a href="#83f0b13548ac43fe13b1813fb407249ff9b825f7">
compiler/GHC/HsToCore/GuardedRHSs.hs
</a>
</li>
<li class="file-stats">
<a href="#085703923f9c18f6ac9f926ac9a4c7c7e6d9d9ed">
compiler/GHC/HsToCore/Match.hs
</a>
</li>
<li class="file-stats">
<a href="#c8a27621f82549165d8946ae8e9f467660958059">
compiler/GHC/HsToCore/Monad.hs
</a>
</li>
<li class="file-stats">
<a href="#ac0a6473a902628a18b3a470122e5cc1ce09de14">
compiler/GHC/HsToCore/PmCheck.hs
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/-/compare/9eb1f47ae367b973948acb4d5e595722b3cc5de6...5390abaafec8bb8328f3db96aa322da505c980fa">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.haskell.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>