<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Ryan Scott pushed to branch wip/dont-remove-integer-gmp-ghc-mk-maintainer-clean
at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/-/commit/2b49e06ef180c5e174056fe2058e555bc10d4a15">2b49e06e</a></strong>
<div>
<span>by Ryan Scott</span>
<i>at 2020-06-25T11:13:31-04:00</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Don't maintainer-clean libraries/integer-gmp/ghc.mk (#16953)
Commit 9f96bc127d6 checked `libraries/integer-gmp/ghc.mk` into
version control, but `make maintainer-clean` mistakenly removes this
file. In the same spirit as commit
257d1fd86e6e5e7d145d71707904d8fe54024041, let's make sure that
`ghc.mk` adds an exemption for this file.
[ci skip]
</pre>
</li>
</ul>
<h4>1 changed file:</h4>
<ul>
<li class="file-stats">
<a href="#8bdb62b981f38737157a853655e494433eea6796">
ghc.mk
</a>
</li>
</ul>
<h4>Changes:</h4>
<li id="8bdb62b981f38737157a853655e494433eea6796">
<a href="https://gitlab.haskell.org/ghc/ghc/-/commit/2b49e06ef180c5e174056fe2058e555bc10d4a15#8bdb62b981f38737157a853655e494433eea6796"><strong>ghc.mk</strong></a>
<hr>
<table class="code white" style="font-family: monospace; font-size: 90%;" bgcolor="#fff" width="100%" cellpadding="0" cellspacing="0">
<tr class="line_holder match" id="" style="line-height: 1.6;">
<td class="diff-line-num unfold js-unfold old_line" data-linenumber="1421" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="diff-line-num unfold js-unfold new_line" data-linenumber="1421" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">...</td>
<td class="line_content match " style="padding-left: 0.5em; padding-right: 0.5em; color: rgba(0,0,0,0.3);" bgcolor="#fafafa">@@ -1421,8 +1421,9 @@ distclean : clean</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1421" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1421
</td>
<td class="diff-line-num new_line" data-linenumber="1421" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1421
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1421" class="line" lang="make"> <span class="err" style="color: #a61717; background-color: #e3d2d2;">$(call</span> <span class="err" style="color: #a61717; background-color: #e3d2d2;">removeFiles,libraries/base/cbits/fs.c)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1422" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1422
</td>
<td class="diff-line-num new_line" data-linenumber="1422" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1422
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1422" class="line" lang="make"></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1423" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1423
</td>
<td class="diff-line-num new_line" data-linenumber="1423" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1423
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1423" class="line" lang="make"><span class="nv" style="color: #008080;">CLEAN_LIBRARY_GHC_MK_FILES</span> <span class="o" style="font-weight: 600;">+=</span> <span class="nf" style="color: #900; font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">patsubst</span> %, libraries/%/ghc.mk, <span class="nv" style="color: #008080;">$(PACKAGES_STAGE1)</span> <span class="nv" style="color: #008080;">$(PACKAGES_STAGE2)</span><span class="nf" style="color: #900; font-weight: 600;">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder old" id="" style="line-height: 1.6;">
<td class="diff-line-num old old_line" data-linenumber="1424" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
1424
</td>
<td class="diff-line-num new_line old" data-linenumber="1424" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #fac5cd; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#f9d7dc">
</td>
<td class="line_content old" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#fbe9eb">
<pre style="margin: 0;">-<span id="LC1424" class="line" lang="make"><span class="c" style="color: #998; font-style: italic;"># Don't clean `libraries/<span class="idiff left right">ghc-boot/ghc.mk`, since it's</span> intended to be version-controlled (#16953)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="1425" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1424" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1424
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1424" class="line" lang="make"><span class="c" style="color: #998; font-style: italic;"># Don't clean `libraries/<span class="idiff left right">{ghc-boot,integer-gmp}/ghc.mk`, since they're</span> intended to be version-controlled (#16953)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1425" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1425
</td>
<td class="diff-line-num new_line" data-linenumber="1425" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1425
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1425" class="line" lang="make"><span class="nv" style="color: #008080;">CLEAN_LIBRARY_GHC_MK_FILES</span> <span class="o" style="font-weight: 600;">:=</span> <span class="nf" style="color: #900; font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">filter-out</span> libraries/ghc-boot/ghc.mk,<span class="nv" style="color: #008080;">$(CLEAN_LIBRARY_GHC_MK_FILES)</span><span class="nf" style="color: #900; font-weight: 600;">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder new" id="" style="line-height: 1.6;">
<td class="diff-line-num new old_line" data-linenumber="1426" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
</td>
<td class="diff-line-num new new_line" data-linenumber="1426" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #c7f0d2; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#ddfbe6">
1426
</td>
<td class="line_content new" style="padding-left: 0.5em; padding-right: 0.5em;" bgcolor="#ecfdf0">
<pre style="margin: 0;">+<span id="LC1426" class="line" lang="make"><span class="nv" style="color: #008080;">CLEAN_LIBRARY_GHC_MK_FILES</span> <span class="o" style="font-weight: 600;">:=</span> <span class="nf" style="color: #900; font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">filter-out</span> libraries/integer-gmp/ghc.mk,<span class="nv" style="color: #008080;">$(CLEAN_LIBRARY_GHC_MK_FILES)</span><span class="nf" style="color: #900; font-weight: 600;">)</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1426" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1426
</td>
<td class="diff-line-num new_line" data-linenumber="1427" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1427
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1427" class="line" lang="make"></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1427" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1427
</td>
<td class="diff-line-num new_line" data-linenumber="1428" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1428
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1428" class="line" lang="make"><span class="nl">maintainer-clean </span><span class="o" style="font-weight: 600;">:</span> <span class="nf" style="color: #900; font-weight: 600;">distclean</span></span>
</pre>
</td>
</tr>
<tr class="line_holder" id="" style="line-height: 1.6;">
<td class="diff-line-num old_line" data-linenumber="1428" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1428
</td>
<td class="diff-line-num new_line" data-linenumber="1429" style="width: 35px; color: rgba(0,0,0,0.3); border-right-width: 1px; border-right-color: #f0f0f0; border-right-style: solid; padding: 0 5px;" align="right" bgcolor="#fafafa">
1429
</td>
<td class="line_content" style="padding-left: 0.5em; padding-right: 0.5em;">
<pre style="margin: 0;"> <span id="LC1429" class="line" lang="make"> <span class="nf" style="color: #900; font-weight: 600;">$(</span><span class="nb" style="color: #0086b3;">call</span> removeFiles,configure mk/config.h.in<span class="nf" style="color: #900; font-weight: 600;">)</span></span>
</pre>
</td>
</tr>
</table>
<br>
</li>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/-/commit/2b49e06ef180c5e174056fe2058e555bc10d4a15">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.haskell.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","action":{"@type":"ViewAction","name":"View Commit","url":"https://gitlab.haskell.org/ghc/ghc/-/commit/2b49e06ef180c5e174056fe2058e555bc10d4a15"}}</script>
</p>
</div>
</body>
</html>