<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">
<html lang="en">
<head>
<meta content="text/html; charset=US-ASCII" http-equiv="Content-Type">
<title>
GitLab
</title>
<style>img {
max-width: 100%; height: auto;
}
</style>
</head>
<body>
<div class="content">
<h3>
Ben Gamari pushed to branch wip/T16728
at <a href="https://gitlab.haskell.org/ghc/ghc">Glasgow Haskell Compiler / GHC</a>
</h3>
<h4>
Commits:
</h4>
<ul>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/1a3420cabdcf6d7d90c154681230f1150604c097">1a3420ca</a></strong>
<div>
<span>by Ben Gamari</span>
<i>at 2019-06-10T11:59:41Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">base: Mark CPUTime001 as fragile
As noted in #16224, CPUTime001 has been quite problematic, reporting
non-monotonic timestamps in CI. Unfortunately I've been unable to
reproduce this locally.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/9bc10993bb300d3712b0f13ec6e28621d75d4204">9bc10993</a></strong>
<div>
<span>by Vladislav Zavialov</span>
<i>at 2019-06-10T12:00:16Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Print role annotations in TemplateHaskell brackets (#16718)
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/0345b1b0f62c8fac72d07a7b848d14b9893e9ac9">0345b1b0</a></strong>
<div>
<span>by Richard Eisenberg</span>
<i>at 2019-06-11T03:52:10Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Comments only: document newtypes' DataConWrapId
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/58a5d728d0293110d7e80aa1f067721447b20882">58a5d728</a></strong>
<div>
<span>by David Eichmann</span>
<i>at 2019-06-11T03:52:50Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Refactor the rules for .hi and .o into a single rule using `&%>` #16764
Currently the rule for .hi files just triggers (via need) the rule
for the .o file, and .o rule generates both the .o and .hi file.
Likewise for .o-boot and .hi-boot files. This is a bit of an abuse
of Shake, and in fact shake supports rules with multiple output
with the &%> function. This exact use case appears in Neil
Mitchell's paper *Shake Before Building* section 6.3.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/2f9450864b355269a102216292f2034f0f7bedda">2f945086</a></strong>
<div>
<span>by Ben Gamari</span>
<i>at 2019-06-11T03:53:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">testsuite: Fix and extend closure_size test
This was previously broken in several ways. This is fixed and it also
now tests arrays. Unfortunately I was unable to find a way to continue
testing PAP and FUN sizes; these simply depend too much upon the
behavior of the simplifier.
I also tried to extend this to test non-empty arrays as well but
unfortunately this was non-trivial as the array card size constant isn't
readily available from haskell.
Fixes #16531.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/e5d275f45677ed89df310754973a15c522dc1003">e5d275f4</a></strong>
<div>
<span>by Ben Gamari</span>
<i>at 2019-06-11T03:53:25Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">ghc-heap: Add closure_size_noopt test
This adds a new test, only run in the `normal` way, to verify the size
of FUNs and PAPs.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/4b4d034fa784776f8905499dcb78f120f510fad4">4b4d034f</a></strong>
<div>
<span>by Simon Peyton Jones</span>
<i>at 2019-06-11T04:57:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix two places that failed the substitution invariant
The substition invariant relies on keeping the in-scope
set in sync, and we weren't always doing so, which means that
a DEBUG compiler crashes sometimes with an assertion failure
This patch fixes a couple more cases. Still not validate
clean (with -DEEBUG) but closer!
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/cc962b22d161d94bcfa0db27de7c77b772f240be">cc962b22</a></strong>
<div>
<span>by Simon Peyton Jones</span>
<i>at 2019-06-11T04:57:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Fix typechecking of partial type signatures
Partial type sigs had grown hair. tcHsParialSigType was
doing lots of unnecessary work, and tcInstSig was cloning it
unnecessarily -- and the result didn't even work: #16728.
This patch cleans it all up, described by TcHsType
Note [Checking parital type signatures]
I basically just deleted code... but very carefully!
Some refactoring along the way
* Distinguish more explicintly between "anonymous" wildcards "_"
and "named" wildcards "_a". I changed the names of a number
of functions to make this distinction much more apparent.
The patch also revealed that the code in `TcExpr`
that implements the special typing rule for `($)` was wrong.
It called `getRuntimeRep` in a situation where where was no
particular reason to suppose that the thing had kind `TYPE r`.
This caused a crash in typecheck/should_run/T10846.
The fix was easy, and actually simplifies the code in `TcExpr`
quite a bit. Hooray.
</pre>
</li>
<li>
<strong><a href="https://gitlab.haskell.org/ghc/ghc/commit/322276e0f1d16dc94579c6b4f2e18f765167a29d">322276e0</a></strong>
<div>
<span>by Simon Peyton Jones</span>
<i>at 2019-06-11T04:57:11Z</i>
</div>
<pre class="commit-message" style="white-space: pre-wrap; margin: 0;">Comments and tiny refactor
* Added Note [Quantified varaibles in partial type signatures]
in TcRnTypes
* Kill dVarSetElemsWellScoped; it was only called in
one function, quantifyTyVars. I inlined it because it
was only scopedSort . dVarSetElems
* Kill Type.tyCoVarsOfBindersWellScoped, never called.
</pre>
</li>
</ul>
<h4>30 changed files:</h4>
<ul>
<li class="file-stats">
<a href="#2f8fee2abca5d63f3b2a113efc849e4e6054c49a">
compiler/basicTypes/MkId.hs
</a>
</li>
<li class="file-stats">
<a href="#0db90e3d6e6150a586bbd58f75f250c3c71766f9">
compiler/hsSyn/HsDecls.hs
</a>
</li>
<li class="file-stats">
<a href="#80d26d5d3ff0c380bfa505239d3192d66657fe32">
compiler/rename/RnTypes.hs
</a>
</li>
<li class="file-stats">
<a href="#c445afcfc673671d106f586e133959854186d16b">
compiler/typecheck/Inst.hs
</a>
</li>
<li class="file-stats">
<a href="#a83766f600de0ac03e19fb4b379bc90111dc73a5">
compiler/typecheck/TcBinds.hs
</a>
</li>
<li class="file-stats">
<a href="#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a">
compiler/typecheck/TcCanonical.hs
</a>
</li>
<li class="file-stats">
<a href="#3668e5951898e1cee434d7e6fb5a139287ebe70d">
compiler/typecheck/TcExpr.hs
</a>
</li>
<li class="file-stats">
<a href="#350c4076427c611b8f14e875a4ca553041c2b847">
compiler/typecheck/TcHsType.hs
</a>
</li>
<li class="file-stats">
<a href="#367db94fc37c8c7548dbe545a5302c7a5108e41e">
compiler/typecheck/TcMType.hs
</a>
</li>
<li class="file-stats">
<a href="#2799ba786adc98d485fad6003334b913a0069bdc">
compiler/typecheck/TcRnDriver.hs
</a>
</li>
<li class="file-stats">
<a href="#fa5bd207fd28db668d069147fd989ad2ac810fd7">
compiler/typecheck/TcRnMonad.hs
</a>
</li>
<li class="file-stats">
<a href="#d2ddf5ce2d076f8584d9825af8ea0d7ea0a38813">
compiler/typecheck/TcRnTypes.hs
</a>
</li>
<li class="file-stats">
<a href="#341aef35ac370771edf59ec6b9fbb31507fa6f18">
compiler/typecheck/TcSigs.hs
</a>
</li>
<li class="file-stats">
<a href="#341fd962c5f2c9fcf8be3dbdaa9a14ee1538af07">
compiler/typecheck/TcType.hs
</a>
</li>
<li class="file-stats">
<a href="#07ce9a046fb8ea6659690020b0a8551d94cfdf1c">
compiler/types/Type.hs
</a>
</li>
<li class="file-stats">
<a href="#46e816779a90d15b358d4f136787e050d605d4c4">
hadrian/src/Rules/Compile.hs
</a>
</li>
<li class="file-stats">
<a href="#b817c80cbb15890d9a6df41e91d15d7442471f3c">
libraries/base/tests/all.T
</a>
</li>
<li class="file-stats">
<a href="#c1919b622c50fbe7e6eaf72df97ab8d0a19e5066">
<span class="new-file">
+
libraries/ghc-heap/tests/ClosureSizeUtils.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#e7e177c17e4bf37dc865a39cde7a0ec9e1a33362">
libraries/ghc-heap/tests/all.T
</a>
</li>
<li class="file-stats">
<a href="#19eaef86aaa1a59e49fbfcaee8e8b07544562ae4">
libraries/ghc-heap/tests/closure_size.hs
</a>
</li>
<li class="file-stats">
<a href="#5c38c00f4d2eef598c1e76edb87a866f403d0d9d">
<span class="new-file">
+
libraries/ghc-heap/tests/closure_size_noopt.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#fc93b26a3154f102f2bf16cf72ae4576f234d0f4">
<span class="new-file">
+
testsuite/tests/partial-sigs/should_compile/T16728.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#b16a1ffd67ffd8fd4e68341503bf44c581910108">
<span class="new-file">
+
testsuite/tests/partial-sigs/should_compile/T16728.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#65238b2bc6d63b92c18503e1d45d68c4641cda65">
<span class="new-file">
+
testsuite/tests/partial-sigs/should_compile/T16728a.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#8998d74383852482788d62775428d5c578125347">
<span class="new-file">
+
testsuite/tests/partial-sigs/should_compile/T16728a.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#d6d32f1b07f8052f82e7678e4a15e0cf57b827c1">
<span class="new-file">
+
testsuite/tests/partial-sigs/should_compile/T16728b.hs
</span>
</a>
</li>
<li class="file-stats">
<a href="#befe36efee69935add9af6dc4b7a849aa1be3241">
<span class="new-file">
+
testsuite/tests/partial-sigs/should_compile/T16728b.stderr
</span>
</a>
</li>
<li class="file-stats">
<a href="#638bf502d5c9ded68b185325d908464f7da3dcac">
testsuite/tests/partial-sigs/should_compile/all.T
</a>
</li>
<li class="file-stats">
<a href="#f745b3f653a464a3341ae5abc26753bc68ee88cd">
testsuite/tests/partial-sigs/should_fail/T14040a.stderr
</a>
</li>
<li class="file-stats">
<a href="#33996de14fdc1ebc68e2c5426279a5beb0523465">
<span class="new-file">
+
testsuite/tests/roles/should_compile/T16718.hs
</span>
</a>
</li>
</ul>
<h5>The diff was not included because it is too large.</h5>
</div>
<div class="footer" style="margin-top: 10px;">
<p style="font-size: small; color: #777;">
—
<br>
<a href="https://gitlab.haskell.org/ghc/ghc/compare/df9a853a1aa58a8d5eb713920605ac651ed64eda...322276e0f1d16dc94579c6b4f2e18f765167a29d">View it on GitLab</a>.
<br>
You're receiving this email because of your account on gitlab.haskell.org.
If you'd like to receive fewer emails, you can
adjust your notification settings.
</p>
</div>
</body>
</html>