[Git][ghc/ghc][wip/az/locateda-epa-improve-2023-07-15] 14 commits: EPA: splitLHsForAllTyInvis no ann returned

[Alan Zimmerman (@alanz)]

Alan Zimmerman pushed to branch wip/az/locateda-epa-improve-2023-07-15 at Glasgow Haskell Compiler / GHC


Commits:
77499a45 by Alan Zimmerman at 2023-07-31T19:28:27+01:00
EPA: splitLHsForAllTyInvis no ann returned

- - - - -
02b3d6c7 by Alan Zimmerman at 2023-08-01T18:27:09+01:00
EPA: Replace Monoid with NoAnn

- - - - -
a15bb609 by Alan Zimmerman at 2023-08-01T20:21:09+01:00
EPA: Use SrcSpan in EpaSpan

- - - - -
e83e5e55 by Alan Zimmerman at 2023-08-03T22:10:20+01:00
EPA: Present no longer has annotation

- - - - -
082887a2 by Alan Zimmerman at 2023-08-05T11:03:47+01:00
EPA: empty tup_tail has no ann

Parser.y: tup_tail rule was
          | {- empty -} %shift   { return [Left noAnn] }

This means we add an extra Missing constructor if the last item was a comma.

Change the annotation type to a Bool to indicate this, and use the
EpAnn Anchor for the print location for the others.

- - - - -
f0690070 by Alan Zimmerman at 2023-08-05T18:48:36+01:00
EPA: Remove parenthesizeHsType

- - - - -
1886a937 by Alan Zimmerman at 2023-08-06T10:25:19+01:00
EPA: Remove EpAnnNotUsed

- - - - -
93248fb1 by Alan Zimmerman at 2023-08-06T10:52:43+01:00
Put BufSpan into RealSrcSpan

This has been superseded by !9473, which moved BufSpan into EpaSpan in
EpaLocation

Start on making LocatedN more direct

Using EpaLocation instead of Anchor

Via a synonym initially, to prove the concept

Variants of AnnSortKey

For future, just a list of which type comes next.
Example for ValBinds

EPA: Explicitly capture EOF Location in AnnsModule

And also get rid of EpaEofComment.

- - - - -
2aa1db55 by Alan Zimmerman at 2023-08-06T10:52:48+01:00
[EPA] Simplify noAnnSrcSpanDP0

- - - - -
aa2c2d65 by Alan Zimmerman at 2023-08-06T10:52:48+01:00
Clean up addTrailingCommaN

Remove unused parameter

- - - - -
3b74a2f6 by Alan Zimmerman at 2023-08-06T10:52:48+01:00
EPA: Move TrailingAnns to the top of FieldOcc

- - - - -
6d253a06 by Alan Zimmerman at 2023-08-06T10:52:48+01:00
EPA: Improve annotation management in getMonoBind

Ensure the LHsDecl for a FunBind has the correct leading comments and
trailing annotations.

See the added note for details.

- - - - -
8c06607d by Alan Zimmerman at 2023-08-06T10:52:48+01:00
EPA: Add '=>' to TrailingAnn

This is used as a trailing annotation in a context.
Add its normal and unicode variants.

Note that we keep the parsed representation the same, but make use of
it when exact printing.

- - - - -
c0b4ebd1 by Alan Zimmerman at 2023-08-06T10:52:48+01:00
EPA: Improve WrapXRec instance

- - - - -


30 changed files:

- compiler/GHC/Data/BooleanFormula.hs
- compiler/GHC/Hs.hs
- compiler/GHC/Hs/Binds.hs
- compiler/GHC/Hs/Decls.hs
- compiler/GHC/Hs/Dump.hs
- compiler/GHC/Hs/Expr.hs
- compiler/GHC/Hs/Extension.hs
- compiler/GHC/Hs/ImpExp.hs
- compiler/GHC/Hs/Pat.hs
- compiler/GHC/Hs/Type.hs
- compiler/GHC/Hs/Utils.hs
- compiler/GHC/HsToCore/Arrows.hs
- compiler/GHC/HsToCore/Docs.hs
- compiler/GHC/HsToCore/Monad.hs
- compiler/GHC/HsToCore/Quote.hs
- compiler/GHC/Iface/Ext/Ast.hs
- compiler/GHC/Iface/Ext/Utils.hs
- compiler/GHC/Parser.y
- compiler/GHC/Parser/Annotation.hs
- compiler/GHC/Parser/Lexer.x
- compiler/GHC/Parser/PostProcess.hs
- compiler/GHC/Parser/PostProcess/Haddock.hs
- compiler/GHC/Parser/Types.hs
- compiler/GHC/Rename/Bind.hs
- compiler/GHC/Rename/Env.hs
- compiler/GHC/Rename/Expr.hs
- compiler/GHC/Rename/HsType.hs
- compiler/GHC/Rename/Module.hs
- compiler/GHC/Rename/Names.hs
- compiler/GHC/Rename/Pat.hs


The diff was not included because it is too large.


View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/b8a6a58fbb4138eec6d34ee0af930500ea7090f5...c0b4ebd101374b3c3d864bf22de82ea169005a45

-- 
View it on GitLab: https://gitlab.haskell.org/ghc/ghc/-/compare/b8a6a58fbb4138eec6d34ee0af930500ea7090f5...c0b4ebd101374b3c3d864bf22de82ea169005a45
You're receiving this email because of your account on gitlab.haskell.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.haskell.org/pipermail/ghc-commits/attachments/20230806/762bfca0/attachment.html>