[commit: ghc] master: Revert "compiler: Write .o files atomically. See #14533" (e6ce174)

git at git.haskell.org git at git.haskell.org
Mon Mar 4 21:05:02 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/e6ce17433b75c6c985bffaf1f6fc18d299666ccb/ghc

>---------------------------------------------------------------

commit e6ce17433b75c6c985bffaf1f6fc18d299666ccb
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Sun Mar 3 00:16:08 2019 -0500

    Revert "compiler: Write .o files atomically. See #14533"
    
    This reverts commit 0e2d300a59b1b5c167d2e7d99a448c8663ba6d7d.


>---------------------------------------------------------------

e6ce17433b75c6c985bffaf1f6fc18d299666ccb
 compiler/main/DriverPipeline.hs | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/compiler/main/DriverPipeline.hs b/compiler/main/DriverPipeline.hs
index 3f59ed3..5fe2362 100644
--- a/compiler/main/DriverPipeline.hs
+++ b/compiler/main/DriverPipeline.hs
@@ -1375,12 +1375,7 @@ runPhase (RealPhase (As with_cpp)) input_fn dflags
                           ])
 
         liftIO $ debugTraceMsg dflags 4 (text "Running the assembler")
-
-        -- Atomic write by writing to temp file and then renaming
-        let temp_output_fn = output_fn <.> "tmp"
-        runAssembler input_fn temp_output_fn
-        liftIO $ renameFile temp_output_fn output_fn
-
+        runAssembler input_fn output_fn
         return (RealPhase next_phase, output_fn)
 
 



More information about the ghc-commits mailing list