[commit: ghc] wip/T16087, wip/T16254, wip/junit-unexpected-passes: Use sigPrec in more places in Convert and HsUtils (b1e569a)

git at git.haskell.org git at git.haskell.org
Wed Jan 30 00:26:02 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branches: wip/T16087,wip/T16254,wip/junit-unexpected-passes
Link       : http://ghc.haskell.org/trac/ghc/changeset/b1e569a54085bf1093b4f858f8c7c739e3be769b/ghc

>---------------------------------------------------------------

commit b1e569a54085bf1093b4f858f8c7c739e3be769b
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date:   Mon Jan 14 21:45:17 2019 -0500

    Use sigPrec in more places in Convert and HsUtils
    
    Trac #16183 was caused by TH conversion (in `Convert`) not properly
    inserting parentheses around occurrences of explicit signatures where
    appropriate, such as in applications, function types, and type family
    equations. Solution: use `parenthesizeHsType sigPrec` in these
    places. While I was in town, I also updated `nlHsFunTy` to do the
    same thing.


>---------------------------------------------------------------

b1e569a54085bf1093b4f858f8c7c739e3be769b
 compiler/hsSyn/Convert.hs           | 67 +++++++++++++++++++------------------
 compiler/hsSyn/HsUtils.hs           |  8 +----
 testsuite/tests/th/T12045TH1.stderr |  4 +--
 testsuite/tests/th/T16183.hs        | 11 ++++++
 testsuite/tests/th/T16183.stderr    | 12 +++++++
 testsuite/tests/th/all.T            |  1 +
 6 files changed, 62 insertions(+), 41 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc b1e569a54085bf1093b4f858f8c7c739e3be769b


More information about the ghc-commits mailing list