[commit: ghc] master: gitlab: Add merge request template (5ebcfc0)

git at git.haskell.org git at git.haskell.org
Mon Jan 21 23:06:49 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/5ebcfc0407e6c74abcb259f1482a63c3203ca9e1/ghc

>---------------------------------------------------------------

commit 5ebcfc0407e6c74abcb259f1482a63c3203ca9e1
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Sat Jan 19 15:47:33 2019 -0500

    gitlab: Add merge request template
    
    This begins to define our expectations of contributions.
    
    [skip-ci]


>---------------------------------------------------------------

5ebcfc0407e6c74abcb259f1482a63c3203ca9e1
 .gitlab/merge_request_templates/merge-request.md | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/.gitlab/merge_request_templates/merge-request.md b/.gitlab/merge_request_templates/merge-request.md
new file mode 100644
index 0000000..7216cb2
--- /dev/null
+++ b/.gitlab/merge_request_templates/merge-request.md
@@ -0,0 +1,19 @@
+Thank you for your contribution to GHC!
+
+Please take a few moments to verify that your commits fulfill the following:
+
+ * [ ] are either individually buildable or squashed
+ * [ ] have commit messages which describe *what they do*
+   (referring to [Notes][notes] and tickets using `#NNNN` syntax when
+   appropriate)
+ * [ ] have added source comments describing your change. For larger changes you
+   likely should add a [Note][notes] and cross-reference it from the relevant
+   places.
+ * [ ] add a [testcase to the
+   testsuite](https://ghc.haskell.org/trac/ghc/wiki/Building/RunningTests/Adding).
+
+If you have any questions don't hesitate to open your merge request and inquire
+in a comment. If your patch isn't quite done yet please do add prefix your MR
+title with `WIP:`.
+
+[notes]: https://ghc.haskell.org/trac/ghc/wiki/Commentary/CodingStyle#Commentsinthesourcecode



More information about the ghc-commits mailing list