[commit: ghc] wip/T15971, wip/T16150, wip/alp/hadrian-docs-crosslinking, wip/misc-testsuite: fix-submodules: Rip out typing (1c9dab2)

git at git.haskell.org git at git.haskell.org
Wed Jan 9 21:36:01 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branches: wip/T15971,wip/T16150,wip/alp/hadrian-docs-crosslinking,wip/misc-testsuite
Link       : http://ghc.haskell.org/trac/ghc/changeset/1c9dab22f010352884d6f7e5b62251bc4b0cca7c/ghc

>---------------------------------------------------------------

commit 1c9dab22f010352884d6f7e5b62251bc4b0cca7c
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Sat Jan 5 23:34:12 2019 -0500

    fix-submodules: Rip out typing
    
    Debian Jessie only runs Python 3.4, whereas typing was introduced in Python 3.5.


>---------------------------------------------------------------

1c9dab22f010352884d6f7e5b62251bc4b0cca7c
 .gitlab/fix-submodules.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/.gitlab/fix-submodules.py b/.gitlab/fix-submodules.py
index 621d692..548e960 100755
--- a/.gitlab/fix-submodules.py
+++ b/.gitlab/fix-submodules.py
@@ -6,7 +6,6 @@ clone their submodules from its usual location. Otherwise users would need to
 fork all submodules before their CI builds would succeed.
 """
 
-from typing import List, Dict
 from pathlib import Path
 import re
 
@@ -16,7 +15,7 @@ open('.gitmodules', 'w').write(x)
 
 import subprocess
 
-def get_configs(config_file: Path) -> Dict[str, str]:
+def get_configs(config_file):
     args = ['git', 'config', '-f', config_file.as_posix(), '--list']
     out = subprocess.check_output(args)
     configs = {}
@@ -27,7 +26,7 @@ def get_configs(config_file: Path) -> Dict[str, str]:
 
     return configs
 
-def set_config(config_file: Path, key: str, value: str) -> None:
+def set_config(config_file, key, value):
     args = ['git', 'config', '-f', config_file.as_posix(), '--replace', key, value]
     subprocess.check_call(args)
 



More information about the ghc-commits mailing list