[commit: ghc] wip/ghc-8.6-backports: Fix recompilation bug with default class methods (#15970) (08cfa61)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ghc-8.6-backports
Link       : http://ghc.haskell.org/trac/ghc/changeset/08cfa6153171d7289e799b97940f51d322d8dd32/ghc

>---------------------------------------------------------------

commit 08cfa6153171d7289e799b97940f51d322d8dd32
Author: Simon Marlow <marlowsd at gmail.com>
Date:   Tue Dec 11 13:18:47 2018 -0500

    Fix recompilation bug with default class methods (#15970)
    
    If a module uses a class, then it can instantiate the class and
    thereby use its default methods, so we must include the default
    methods when calculating the fingerprint for the class.
    
    Test Plan:
    New unit test: driver/T15970
    
    Before:
    
    ```
    =====> T15970(normal) 1 of 1 [0, 0, 0]
    cd "T15970.run" && $MAKE -s --no-print-directory T15970
    Wrong exit code for T15970()(expected 0 , actual 2 )
    Stdout ( T15970 ):
    Makefile:13: recipe for target 'T15970' failed
    Stderr ( T15970 ):
    C.o:function Main_zdfTypeClassMyDataType1_info: error: undefined
    reference to 'A_toTypedData2_closure'
    C.o:function Main_main1_info: error: undefined reference to
    'A_toTypedData2_closure'
    C.o(.data+0x298): error: undefined reference to 'A_toTypedData2_closure'
    C.o(.data+0x480): error: undefined reference to 'A_toTypedData2_closure'
    collect2: error: ld returned 1 exit status
    `gcc' failed in phase `Linker'. (Exit code: 1)
    ```
    
    After: test passes.
    
    Reviewers: bgamari, simonpj, erikd, watashi, afarmer
    
    Subscribers: rwbarton, carter
    
    GHC Trac Issues: #15970
    
    Differential Revision: https://phabricator.haskell.org/D5394
    
    (cherry picked from commit 288f681e06accbae690c46eb8a6e997fa9e5f56a)


>---------------------------------------------------------------

08cfa6153171d7289e799b97940f51d322d8dd32
 compiler/iface/MkIface.hs              | 78 ++++++++++++++++++++++++++++------
 testsuite/tests/driver/T15970/A1.hs    | 13 ++++++
 testsuite/tests/driver/T15970/A2.hs    | 13 ++++++
 testsuite/tests/driver/T15970/B.hs     |  9 ++++
 testsuite/tests/driver/T15970/C.hs     | 15 +++++++
 testsuite/tests/driver/T15970/Makefile | 17 ++++++++
 testsuite/tests/driver/T15970/all.T    |  2 +
 7 files changed, 134 insertions(+), 13 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 08cfa6153171d7289e799b97940f51d322d8dd32