[commit: ghc] wip/ghc-8.8-merges: Remove TODO in HsExpr (f9bd1cf)

git at git.haskell.org git at git.haskell.org
Thu Feb 21 15:09:22 UTC 2019


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ghc-8.8-merges
Link       : http://ghc.haskell.org/trac/ghc/changeset/f9bd1cfe10fd14a2718dde2e06e1836f95d55e4b/ghc

>---------------------------------------------------------------

commit f9bd1cfe10fd14a2718dde2e06e1836f95d55e4b
Author: Matthew Pickering <matthewtpickering at gmail.com>
Date:   Fri Jan 18 11:36:12 2019 -0500

    Remove TODO in HsExpr
    
    It is correct to be `GhcTc` as the data type is for expressions which are inside splices
    so they can be delayed until desugaring.


>---------------------------------------------------------------

f9bd1cfe10fd14a2718dde2e06e1836f95d55e4b
 compiler/hsSyn/HsExpr.hs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/compiler/hsSyn/HsExpr.hs b/compiler/hsSyn/HsExpr.hs
index 41bbdb2..bae29b0 100644
--- a/compiler/hsSyn/HsExpr.hs
+++ b/compiler/hsSyn/HsExpr.hs
@@ -2486,7 +2486,6 @@ data UntypedSpliceFlavour
 
 -- | Pending Type-checker Splice
 data PendingTcSplice
-  -- AZ:TODO: The hard-coded GhcTc feels wrong.
   = PendingTcSplice SplicePointName (LHsExpr GhcTc)
 
 {-



More information about the ghc-commits mailing list