[commit: ghc] wip/az-D5036-2: [TTG: Handling Source Locations] Foundation and Pat (5ec29fb)

git at git.haskell.org git at git.haskell.org
Wed Oct 24 19:10:07 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/az-D5036-2
Link       : http://ghc.haskell.org/trac/ghc/changeset/5ec29fbc936b5107357ccb497c3a36534f04096d/ghc

>---------------------------------------------------------------

commit 5ec29fbc936b5107357ccb497c3a36534f04096d
Author: Shayan-Najd <sh.najd at gmail.com>
Date:   Tue Oct 23 20:30:54 2018 +0200

    [TTG: Handling Source Locations] Foundation and Pat
    
    Summary:
    - the class `HasSrcSpan`, and its functions (e.g., `cL` and `dL`), are introduced
    - some instances of `HasSrcSpan` are introduced
    - some constructors `L` are replaced with `cL`
    - some patterns `L` are replaced with `dL` view pattern
    - `XPat` is renamed to `NewPat`
    - some type annotation are necessarily updated updated  (e.g., `Pat p` --> `Pat (GhcPass p)`)
    -  (there was a bug in an earlier version of this patch related to using functor on `Located` things that is fixed)
    
    Test Plan:
    - GHC and the related code (e.g., Haddock) fully compile on my Linux system
    - the patch passes the tests and ./Validate
    
    Reviewers: bgamari, alanz, simonpj
    
    Subscribers: mpickering
    
    GHC Trac Issues: #15495
    
    Differential Revision: https://phabricator.haskell.org/D5036


>---------------------------------------------------------------

5ec29fbc936b5107357ccb497c3a36534f04096d
 compiler/basicTypes/Name.hs        |   8 +-
 compiler/basicTypes/SrcLoc.hs      |  80 ++++++--
 compiler/deSugar/Check.hs          |  10 +-
 compiler/deSugar/DsArrows.hs       |   5 +-
 compiler/deSugar/DsExpr.hs         |   2 +-
 compiler/deSugar/DsListComp.hs     |   2 +-
 compiler/deSugar/DsMeta.hs         |   3 +-
 compiler/deSugar/DsUtils.hs        |  45 ++---
 compiler/deSugar/ExtractDocs.hs    |   5 +-
 compiler/deSugar/Match.hs          |  23 +--
 compiler/deSugar/MatchCon.hs       |   3 +-
 compiler/hsSyn/Convert.hs          | 107 ++++++-----
 compiler/hsSyn/HsExtension.hs      |   4 +-
 compiler/hsSyn/HsPat.hs            |  88 +++++----
 compiler/hsSyn/HsPat.hs-boot       |   3 +-
 compiler/hsSyn/HsTypes.hs          |   4 +-
 compiler/hsSyn/HsUtils.hs          | 213 +++++++++++----------
 compiler/main/DynFlags.hs          |   1 +
 compiler/main/GHC.hs               |   4 +
 compiler/main/HeaderInfo.hs        |  74 ++++----
 compiler/main/HscStats.hs          |   4 +-
 compiler/main/HscTypes.hs          |   3 +-
 compiler/parser/Lexer.x            |  30 +--
 compiler/parser/Parser.y           | 106 ++++++-----
 compiler/parser/RdrHsSyn.hs        | 369 +++++++++++++++++++------------------
 compiler/rename/RnBinds.hs         |  10 +-
 compiler/rename/RnExpr.hs          |   7 +-
 compiler/rename/RnPat.hs           |  50 ++---
 compiler/rename/RnSplice.hs        |  14 +-
 compiler/rename/RnTypes.hs         |   9 +-
 compiler/typecheck/TcBinds.hs      |   3 +-
 compiler/typecheck/TcErrors.hs     |   4 +-
 compiler/typecheck/TcHsSyn.hs      |   3 +-
 compiler/typecheck/TcHsType.hs     |   2 +-
 compiler/typecheck/TcPat.hs        |   5 +-
 compiler/typecheck/TcPatSyn.hs     |  15 +-
 compiler/typecheck/TcRnDriver.hs   |   2 +-
 compiler/typecheck/TcRnExports.hs  |   4 +-
 compiler/typecheck/TcRnMonad.hs    |  33 ++--
 compiler/typecheck/TcTyClsDecls.hs |   9 +-
 compiler/typecheck/TcTyDecls.hs    |  19 +-
 compiler/utils/Binary.hs           |   2 +-
 ghc/GHCi/UI/Info.hs                |   7 +-
 testsuite/tests/ghc-api/T6145.hs   |   7 +-
 utils/ghctags/Main.hs              |   3 +-
 45 files changed, 797 insertions(+), 607 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 5ec29fbc936b5107357ccb497c3a36534f04096d


More information about the ghc-commits mailing list