[commit: ghc] master: Schedule.c: remove unreachable code block (d9d4632)

git at git.haskell.org git at git.haskell.org
Wed Mar 7 11:36:08 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/d9d463289fe20316cff12a8f0dbf414db678fa72/ghc

>---------------------------------------------------------------

commit d9d463289fe20316cff12a8f0dbf414db678fa72
Author: Ömer Sinan Ağacan <omeragacan at gmail.com>
Date:   Wed Mar 7 14:34:46 2018 +0300

    Schedule.c: remove unreachable code block


>---------------------------------------------------------------

d9d463289fe20316cff12a8f0dbf414db678fa72
 rts/Schedule.c |  7 -------
 rts/Sparks.c   | 15 ---------------
 2 files changed, 22 deletions(-)

diff --git a/rts/Schedule.c b/rts/Schedule.c
index 885e737..5160cb4 100644
--- a/rts/Schedule.c
+++ b/rts/Schedule.c
@@ -1918,13 +1918,6 @@ delete_threads_and_gc:
             throwToSelf(cap, main_thread, heapOverflow_closure);
         }
     }
-#if defined(SPARKBALANCE)
-    /* JB
-       Once we are all together... this would be the place to balance all
-       spark pools. No concurrent stealing or adding of new sparks can
-       occur. Should be defined in Sparks.c. */
-    balanceSparkPoolsCaps(n_capabilities, capabilities);
-#endif
 
 #if defined(THREADED_RTS)
     stgFree(idle_cap);
diff --git a/rts/Sparks.c b/rts/Sparks.c
index a31a5df..bd5e120 100644
--- a/rts/Sparks.c
+++ b/rts/Sparks.c
@@ -284,21 +284,6 @@ traverseSparkQueue (evac_fn evac, void *user, Capability *cap)
                sparkPoolSize(pool), pool->bottom, pool->top);
 }
 
-/* ----------------------------------------------------------------------------
- * balanceSparkPoolsCaps: takes an array of capabilities (usually: all
- * capabilities) and its size. Accesses all spark pools and equally
- * distributes the sparks among them.
- *
- * Could be called after GC, before Cap. release, from scheduler.
- * -------------------------------------------------------------------------- */
-void balanceSparkPoolsCaps(uint32_t n_caps, Capability caps[])
-   GNUC3_ATTRIBUTE(__noreturn__);
-
-void balanceSparkPoolsCaps(uint32_t n_caps STG_UNUSED,
-                           Capability caps[] STG_UNUSED) {
-  barf("not implemented");
-}
-
 #else
 
 StgInt



More information about the ghc-commits mailing list