[commit: ghc] master: testsuite: Remove expect_broken on readFail032 and readFail048 (7e1d214)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/7e1d214fce064c42df70ae121cedf27ebea853f8/ghc

>---------------------------------------------------------------

commit 7e1d214fce064c42df70ae121cedf27ebea853f8
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Sat Dec 22 09:49:28 2018 -0500

    testsuite: Remove expect_broken on readFail032 and readFail048
    
    As noted in #15662, these used to be broken on Darwin due to a Clang toolchain
    bug. However, this bug appears to be fixed in the Clang shipped with macOS
    Mojave. Unfortunately, we don't really have any way to only mark it as broken on
    certain operation system releases so I am just removing the expect_broken
    entirely.


>---------------------------------------------------------------

7e1d214fce064c42df70ae121cedf27ebea853f8
 testsuite/tests/parser/should_fail/all.T | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/testsuite/tests/parser/should_fail/all.T b/testsuite/tests/parser/should_fail/all.T
index d5c40c1..f1f5122 100644
--- a/testsuite/tests/parser/should_fail/all.T
+++ b/testsuite/tests/parser/should_fail/all.T
@@ -35,8 +35,10 @@ test('readFail028', normal, compile_fail, [''])
 test('readFail029', normal, compile_fail, [''])
 test('readFail030', normal, compile_fail, [''])
 test('readFail031', normal, compile_fail, [''])
-test('readFail032', when(opsys('darwin'), expect_broken(15662)),
-     compile_fail, ['-cpp'])
+# N.B. readFail032 and readFail048 used to fail on Darwin
+# due to a toolchain bug (#15662). This appears to be fixed in
+# Mojave but will likely still fail on earlier releases.
+test('readFail032', normal, compile_fail, ['-cpp'])
 test('readFail033', normal, compile_fail, [''])
 test('readFail034', normal, compile_fail, [''])
 test('readFail035', normal, compile_fail, [''])
@@ -51,8 +53,8 @@ test('readFail043', normal, compile_fail, [''])
 test('readFail044', normal, compile_fail, [''])
 test('readFail046', normal, compile_fail, [''])
 test('readFail047', normal, compile_fail, [''])
-test('readFail048', when(opsys('darwin'), expect_broken(15662)),
-     compile_fail, ['-cpp -haddock'])
+# See comment attached to readFail032 above.
+test('readFail048', normal, compile_fail, ['-cpp -haddock'])
 test('T3095', normal, compile_fail, [''])
 test('T3153', normal, compile_fail, [''])
 test('T3751', normal, compile_fail, [''])