[commit: ghc] master: Rename kind vars in left-to-right order in bindHsQTyVars (102284e)

git at git.haskell.org git at git.haskell.org
Tue Aug 28 22:12:24 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/102284e72f8d29599803aa72ccec180db28e72c8/ghc

>---------------------------------------------------------------

commit 102284e72f8d29599803aa72ccec180db28e72c8
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date:   Tue Aug 28 22:58:52 2018 +0200

    Rename kind vars in left-to-right order in bindHsQTyVars
    
    Summary:
    When renaming kind variables in an `LHsQTyVars`, we were
    erroneously putting all of the kind variables in the binders
    //after// the kind variables in the body, resulting in #15568. The
    fix is simple: just swap the order of these two around.
    
    Test Plan: make test TEST=T15568
    
    Reviewers: simonpj, bgamari, goldfire
    
    Reviewed By: goldfire
    
    Subscribers: goldfire, rwbarton, carter
    
    GHC Trac Issues: #15568
    
    Differential Revision: https://phabricator.haskell.org/D5108


>---------------------------------------------------------------

102284e72f8d29599803aa72ccec180db28e72c8
 compiler/hsSyn/HsTypes.hs                          | 17 ++++-
 compiler/rename/RnTypes.hs                         | 86 +++++++++++++++++++---
 compiler/typecheck/TcHsType.hs                     |  2 +-
 compiler/types/Type.hs                             |  2 +-
 docs/users_guide/glasgow_exts.rst                  | 11 +++
 testsuite/tests/ghci/scripts/T15568.hs             |  7 ++
 testsuite/tests/ghci/scripts/T15568.script         |  4 +
 testsuite/tests/ghci/scripts/T15568.stdout         |  2 +
 testsuite/tests/ghci/scripts/T6018ghcifail.stderr  |  2 +-
 testsuite/tests/ghci/scripts/all.T                 |  1 +
 testsuite/tests/polykinds/T11821a.stderr           |  2 +-
 testsuite/tests/polykinds/T14520.stderr            |  2 +-
 .../tests/typecheck/should_fail/T6018fail.stderr   |  2 +-
 13 files changed, 123 insertions(+), 17 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 102284e72f8d29599803aa72ccec180db28e72c8


More information about the ghc-commits mailing list