[commit: ghc] master: Plugin dependency information is stored separately (52065e9)

git at git.haskell.org git at git.haskell.org
Wed Aug 1 23:39:19 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/52065e95c6df89d0048c6e3f35d6cc26ce8246f9/ghc

>---------------------------------------------------------------

commit 52065e95c6df89d0048c6e3f35d6cc26ce8246f9
Author: Christiaan Baaij <christiaan.baaij at gmail.com>
Date:   Wed Aug 1 14:21:22 2018 -0400

    Plugin dependency information is stored separately
    
    We need to store the used plugins so that we recompile
    a module when a plugin that it uses is recompiled.
    
    However, storing the `ModuleName`s of the plugins used by a
    module in the `dep_mods` field made the rest of GHC think
    that they belong in the HPT, causing at least the issues
    reported in #15234
    
    We therefor store the `ModuleName`s of the plugins in a
    new field, `dep_plgins`, which is only used the the
    recompilation logic.
    
    Reviewers: mpickering, bgamari
    
    Reviewed By: mpickering, bgamari
    
    Subscribers: alpmestan, rwbarton, thomie, carter
    
    GHC Trac Issues: #15234
    
    Differential Revision: https://phabricator.haskell.org/D4937


>---------------------------------------------------------------

52065e95c6df89d0048c6e3f35d6cc26ce8246f9
 compiler/deSugar/Desugar.hs                        |   5 +-
 compiler/deSugar/DsUsage.hs                        | 103 ++++++++++++++++++++-
 compiler/iface/MkIface.hs                          |  11 ++-
 compiler/main/DynamicLoading.hs                    |  11 ++-
 compiler/main/HscTypes.hs                          |   9 +-
 compiler/main/Plugins.hs                           |   4 +-
 testsuite/tests/plugins/Makefile                   |   7 ++
 testsuite/tests/plugins/all.T                      |   6 ++
 ...p-impure.stderr => plugin-recomp-change.stderr} |   2 +-
 testsuite/tests/plugins/plugin-recomp/Common.hs    |   5 +
 testsuite/tests/plugins/plugin-recomp/Makefile     |   3 +-
 11 files changed, 145 insertions(+), 21 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 52065e95c6df89d0048c6e3f35d6cc26ce8246f9


More information about the ghc-commits mailing list