[commit: ghc] wip/tdammers/T14737-patch: Fix unintended Haddock (abcecfe)

git at git.haskell.org git at git.haskell.org
Thu Apr 5 12:25:50 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/tdammers/T14737-patch
Link       : http://ghc.haskell.org/trac/ghc/changeset/abcecfe3ffb384a4730adaa1247c9ab4305448d1/ghc

>---------------------------------------------------------------

commit abcecfe3ffb384a4730adaa1247c9ab4305448d1
Author: Tobias Dammers <tdammers at gmail.com>
Date:   Thu Apr 5 14:25:03 2018 +0200

    Fix unintended Haddock


>---------------------------------------------------------------

abcecfe3ffb384a4730adaa1247c9ab4305448d1
 compiler/coreSyn/CoreOpt.hs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/compiler/coreSyn/CoreOpt.hs b/compiler/coreSyn/CoreOpt.hs
index 4b305fa..6c63361 100644
--- a/compiler/coreSyn/CoreOpt.hs
+++ b/compiler/coreSyn/CoreOpt.hs
@@ -960,8 +960,8 @@ pushCoTyArg :: CoercionR -> Type -> Maybe (Type, Maybe CoercionR)
 pushCoTyArg co ty
   -- The following is inefficient - don't do `eqType` here, the coercion
   -- optimizer will take care of it. See Trac #14737.
-  -- | tyL `eqType` tyR
-  -- = Just (ty, Nothing)
+  -- -- | tyL `eqType` tyR
+  -- -- = Just (ty, Nothing)
 
   | isForAllTy tyL
   = ASSERT2( isForAllTy tyR, ppr co $$ ppr ty )
@@ -993,8 +993,10 @@ pushCoValArg :: Coercion -> Maybe (Coercion, Maybe Coercion)
 -- If the second returned Coercion is actually Nothing, then no cast is necessary;
 -- the returned coercion would have been reflexive.
 pushCoValArg co
-  | tyL `eqType` tyR
-  = Just (mkRepReflCo arg, Nothing)
+  -- The following is inefficient - don't do `eqType` here, the coercion
+  -- optimizer will take care of it. See Trac #14737.
+  -- -- | tyL `eqType` tyR
+  -- -- = Just (mkRepReflCo arg, Nothing)
 
   | isFunTy tyL
   , (co1, co2) <- decomposeFunCo co



More information about the ghc-commits mailing list