[commit: ghc] wip/kavon-nosplit-llvm: add todos to improve some things (6fa6a7e)

git at git.haskell.org git at git.haskell.org
Tue Jun 27 09:15:12 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/kavon-nosplit-llvm
Link       : http://ghc.haskell.org/trac/ghc/changeset/6fa6a7ea8f4b5487aeaa71cbab1e83399e2300a7/ghc

>---------------------------------------------------------------

commit 6fa6a7ea8f4b5487aeaa71cbab1e83399e2300a7
Author: Kavon Farvardin <kavon at farvard.in>
Date:   Tue May 16 11:05:32 2017 +0100

    add todos to improve some things


>---------------------------------------------------------------

6fa6a7ea8f4b5487aeaa71cbab1e83399e2300a7
 compiler/llvmGen/LlvmCodeGen/Base.hs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/compiler/llvmGen/LlvmCodeGen/Base.hs b/compiler/llvmGen/LlvmCodeGen/Base.hs
index a4b7f07..7369cdb 100644
--- a/compiler/llvmGen/LlvmCodeGen/Base.hs
+++ b/compiler/llvmGen/LlvmCodeGen/Base.hs
@@ -121,12 +121,12 @@ llvmFunSig live lbl link = do
 
 llvmFunSig' :: LiveGlobalRegs -> LMString -> LlvmLinkageType -> LlvmM LlvmFunctionDecl
 llvmFunSig' live lbl link
-  = do let toParams x | isPointer x = (x, [NoAlias, NoCapture])
+  = do let toParams x | isPointer x = (x, [NoAlias, NoCapture]) -- TODO(kavon): add NonNull
                       | otherwise   = (x, [])
        dflags <- getDynFlags
        -- the standard set of argument types passed/returned.
        let stdConvention = map getVarType (llvmFunArgs dflags live)
-       let retTy = LMStructU $ stdConvention -- TODO: introduce a type alias to reduce bytes output
+       let retTy = LMStructU $ stdConvention -- TODO(kavon): introduce a type alias to reduce bytes output
        return $ LlvmFunctionDecl lbl link (llvmGhcCC dflags) retTy FixedArgs
                                  (map toParams stdConvention)
                                  (llvmFunAlign dflags)



More information about the ghc-commits mailing list