[commit: ghc] master: Initialize hs_init with UTF8 encoded arguments on Windows. (7af0b90)

git at git.haskell.org git at git.haskell.org
Thu Jul 27 20:18:33 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/7af0b906116e13fbd90f43f2f6c6b826df2dca77/ghc

>---------------------------------------------------------------

commit 7af0b906116e13fbd90f43f2f6c6b826df2dca77
Author: Andreas Klebinger <klebinger.andreas at gmx.at>
Date:   Thu Jul 27 18:16:09 2017 +0100

    Initialize hs_init with UTF8 encoded arguments on Windows.
    
    Summary:
    Get utf8 encoded arguments before we call hs_init and use them
    instead of ignoring hs_init arguments. This reduces differing
    behaviour of the RTS between windows and linux and simplifies
    the code involved.
    
    A few testcases were changed to expect the same result on windows
    as on linux after the changes.
    
    This fixes #13940.
    
    Test Plan: ./validate
    
    Reviewers: austin, hvr, bgamari, erikd, simonmar, Phyx
    
    Subscribers: Phyx, rwbarton, thomie
    
    GHC Trac Issues: #13940
    
    Differential Revision: https://phabricator.haskell.org/D3739


>---------------------------------------------------------------

7af0b906116e13fbd90f43f2f6c6b826df2dca77
 docs/users_guide/ffi-chap.rst               |   6 ++
 includes/Rts.h                              |   6 --
 libraries/base/GHC/Environment.hs           |  45 ++--------
 libraries/base/GHC/IO/Encoding.hs           |  12 +++
 libraries/base/System/Environment.hs        |  92 ++------------------
 rts/RtsFlags.c                              | 127 +++++++++++++++++-----------
 rts/RtsFlags.h                              |   5 ++
 rts/RtsMain.c                               |  11 +++
 rts/RtsStartup.c                            |  26 ++++++
 rts/RtsSymbols.c                            |   2 -
 testsuite/tests/ghci.debugger/scripts/all.T |   3 +-
 testsuite/tests/rts/T6006.stdout-mingw32    |   2 +-
 12 files changed, 155 insertions(+), 182 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 7af0b906116e13fbd90f43f2f6c6b826df2dca77


More information about the ghc-commits mailing list