[commit: ghc] master: Derive <$ (2219c8c)

git at git.haskell.org git at git.haskell.org
Tue Feb 7 05:18:14 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/2219c8cd612ec7920a3bd1661b3c663575737267/ghc

>---------------------------------------------------------------

commit 2219c8cd612ec7920a3bd1661b3c663575737267
Author: David Feuer <david.feuer at gmail.com>
Date:   Tue Feb 7 00:16:55 2017 -0500

    Derive <$
    
    Using the default definition of `<$` for derived `Functor`
    instance is very bad for recursive data types. Derive
    the definition instead.
    
    Fixes #13218
    
    Reviewers: austin, bgamari, RyanGlScott
    
    Reviewed By: RyanGlScott
    
    Subscribers: RyanGlScott, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3072


>---------------------------------------------------------------

2219c8cd612ec7920a3bd1661b3c663575737267
 compiler/prelude/PrelNames.hs                      |  10 +-
 compiler/typecheck/TcGenFunctor.hs                 | 154 ++++++++++++++++++++-
 docs/users_guide/8.2.1-notes.rst                   |   5 +
 testsuite/tests/generics/GenDerivOutput.stderr     |   9 +-
 .../tests/generics/T10604/T10604_deriving.stderr   |   7 +-
 testsuite/tests/perf/should_run/T13218.hs          |  26 ++++
 testsuite/tests/perf/should_run/all.T              |  13 ++
 7 files changed, 202 insertions(+), 22 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 2219c8cd612ec7920a3bd1661b3c663575737267


More information about the ghc-commits mailing list