[commit: ghc] wip/T13861: WIP: less noise, and add TODO (98c8190)

git at git.haskell.org git at git.haskell.org
Fri Dec 29 12:28:25 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/T13861
Link       : http://ghc.haskell.org/trac/ghc/changeset/98c819092be44b38d25fa77ba416aec8d70d6409/ghc

>---------------------------------------------------------------

commit 98c819092be44b38d25fa77ba416aec8d70d6409
Author: Gabor Greif <ggreif at gmail.com>
Date:   Fri Dec 29 13:23:50 2017 +0100

    WIP: less noise, and add TODO


>---------------------------------------------------------------

98c819092be44b38d25fa77ba416aec8d70d6409
 compiler/codeGen/StgCmmClosure.hs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/compiler/codeGen/StgCmmClosure.hs b/compiler/codeGen/StgCmmClosure.hs
index 034a641..6566672 100644
--- a/compiler/codeGen/StgCmmClosure.hs
+++ b/compiler/codeGen/StgCmmClosure.hs
@@ -591,10 +591,6 @@ getCallMethod dflags name id (LFReEntrant _ _ arity _ _) n_args _v_args _cg_loc
 getCallMethod _ _name _ LFUnlifted n_args _v_args _cg_loc _self_loop_info
   = ASSERT( n_args == 0 ) ReturnIt
 
-getCallMethod _ name id (LFUnknown False) 0 _v_args cg_loc _self_loop_info
-  | occNameString (nameOccName name) == "wild"
-  = pprTrace "getCallMethod" (ppr id <+> ppr cg_loc) ReturnIt
-
 getCallMethod _ _name _ (LFCon _) n_args _v_args _cg_loc _self_loop_info
   = ASSERT( n_args == 0 ) ReturnIt
     -- n_args=0 because it'd be ill-typed to apply a saturated
@@ -635,6 +631,10 @@ getCallMethod dflags name id (LFThunk _ _ updatable std_form_info is_fun)
 getCallMethod _ _name _ (LFUnknown True) _n_arg _v_args _cg_locs _self_loop_info
   = SlowCall -- might be a function
 
+getCallMethod _ name id (LFUnknown False) 0 _v_args cg_loc _self_loop_info
+  | occNameString (nameOccName name) == "wild" -- TODO: make this robust
+  = ReturnIt -- seems to come from case, must be (tagged) WHNF already
+
 getCallMethod _ name _ (LFUnknown False) n_args _v_args _cg_loc _self_loop_info
   = ASSERT2( n_args == 0, ppr name <+> ppr n_args )
     EnterIt -- Not a function



More information about the ghc-commits mailing list