[commit: ghc] master: Move validate cleaning from distclean to clean (afc2f79)

git at git.haskell.org git at git.haskell.org
Tue Aug 22 15:22:18 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/afc2f7989ea973f201a28d95abb24b22269c5256/ghc

>---------------------------------------------------------------

commit afc2f7989ea973f201a28d95abb24b22269c5256
Author: Douglas Wilson <douglas.wilson at gmail.com>
Date:   Tue Aug 22 08:44:00 2017 -0400

    Move validate cleaning from distclean to clean
    
    This bit me today: I was in validate mode without realising it and "make
    clean" didn't help. I don't see a reason for this to be in distclean, as
    it isn't generated by ./configure, which is the rule described in
    https://ghc.haskell.org/trac/ghc/wiki/Building/Using
    
    Test Plan: Is there a reason for this to be in distclean?
    
    Reviewers: austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3814


>---------------------------------------------------------------

afc2f7989ea973f201a28d95abb24b22269c5256
 ghc.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ghc.mk b/ghc.mk
index 55cc119..4a2f703 100644
--- a/ghc.mk
+++ b/ghc.mk
@@ -1366,6 +1366,8 @@ clean_files :
 	$(call removeTrees,inplace/bin)
 	$(call removeTrees,inplace/lib)
 	$(call removeTrees,libraries/bootstrapping.conf)
+# Clean the files that ./validate creates.
+	$(call removeFiles,mk/are-validating.mk)
 
 .PHONY: clean_libraries
 clean_libraries: $(patsubst %,clean_libraries/%_dist-install,$(PACKAGES_STAGE1) $(PACKAGES_STAGE2))
@@ -1398,9 +1400,6 @@ clean_bindistprep:
 	$(call removeTrees,bindistprep/)
 
 distclean : clean
-# Clean the files that ./validate creates.
-	$(call removeFiles,mk/are-validating.mk)
-
 # Clean the files that we ask ./configure to create.
 	$(call removeFiles,mk/config.mk)
 	$(call removeFiles,mk/install.mk)



More information about the ghc-commits mailing list