[commit: ghc] wip/names3: TysWiredIn: Non-user symbols needn't be handled by isBuiltInOcc (acfc69c)

git at git.haskell.org git at git.haskell.org
Thu Sep 8 18:52:23 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/names3
Link       : http://ghc.haskell.org/trac/ghc/changeset/acfc69c48b187e58e3d4b31ef3c815259cf8b129/ghc

>---------------------------------------------------------------

commit acfc69c48b187e58e3d4b31ef3c815259cf8b129
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Tue Aug 23 08:11:11 2016 -0400

    TysWiredIn: Non-user symbols needn't be handled by isBuiltInOcc


>---------------------------------------------------------------

acfc69c48b187e58e3d4b31ef3c815259cf8b129
 compiler/prelude/TysWiredIn.hs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/compiler/prelude/TysWiredIn.hs b/compiler/prelude/TysWiredIn.hs
index f41edc8..0d53aed 100644
--- a/compiler/prelude/TysWiredIn.hs
+++ b/compiler/prelude/TysWiredIn.hs
@@ -664,11 +664,14 @@ decl in GHC.Classes, so I think this part may not work properly. But
 it's unused I think.
 -}
 
--- | Built in syntax isn't "in scope" so these OccNames map to wired-in Names
+-- | Built-in syntax isn't "in scope" so these OccNames map to wired-in Names
 -- with BuiltInSyntax. However, this should only be necessary while resolving
 -- names produced by Template Haskell splices since we take care to encode
 -- built-in syntax names specially in interface files. See
 -- Note [Symbol table representation of names].
+--
+-- Moreover, there is no need to include names of things that the user can't
+-- write (e.g. type representation bindings like $tc(,,,)).
 isBuiltInOcc_maybe :: OccName -> Maybe Name
 isBuiltInOcc_maybe occ =
     case name of



More information about the ghc-commits mailing list