[commit: ghc] master: Have reify work for local variables with functional dependencies. (231a3ae)

git at git.haskell.org git at git.haskell.org
Thu Nov 17 16:04:19 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/231a3ae1644403c1f295e993105c4346d0db22db/ghc

>---------------------------------------------------------------

commit 231a3ae1644403c1f295e993105c4346d0db22db
Author: Facundo Domínguez <facundo.dominguez at tweag.io>
Date:   Thu Nov 17 10:04:13 2016 -0500

    Have reify work for local variables with functional dependencies.
    
    It turned out that finalizers were run too early and information
    resulting from simplifying constraints was not available.
    
    This patch runs finalizers after a first call to simplifyTop, and
    then calls simplifyTop a second time to deal with constraints
    that could result from running the finalizers.
    
    Fixes T12777
    
    Test Plan: ./validate
    
    Reviewers: goldfire, simonpj, bgamari, austin
    
    Reviewed By: simonpj
    
    Subscribers: mpickering, mboes, thomie
    
    Differential Revision: https://phabricator.haskell.org/D2659
    
    GHC Trac Issues: #12777


>---------------------------------------------------------------

231a3ae1644403c1f295e993105c4346d0db22db
 compiler/typecheck/TcRnDriver.hs             | 50 +++++++++++++++++-----------
 compiler/typecheck/TcRnMonad.hs              | 14 +++++++-
 compiler/typecheck/TcRnTypes.hs              | 25 +++++++++++++-
 testsuite/tests/th/TH_reifyLocalDefs2.hs     | 24 +++++++++++++
 testsuite/tests/th/TH_reifyLocalDefs2.stderr |  1 +
 testsuite/tests/th/all.T                     |  1 +
 6 files changed, 94 insertions(+), 21 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 231a3ae1644403c1f295e993105c4346d0db22db


More information about the ghc-commits mailing list