[commit: ghc] master: Document some benign nondeterminism (4c6e69d)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/4c6e69d58a300d6ef440d326a3fd29b58b284fa1/ghc

>---------------------------------------------------------------

commit 4c6e69d58a300d6ef440d326a3fd29b58b284fa1
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Tue May 24 02:56:59 2016 -0700

    Document some benign nondeterminism
    
    I've changed the functions to their nonDet equivalents and explained
    why they're OK there. This allowed me to remove foldNameSet,
    foldVarEnv, foldVarEnv_Directly, foldVarSet and foldUFM_Directly.
    
    Test Plan: ./validate, there should be no change in behavior
    
    Reviewers: simonpj, simonmar, austin, goldfire, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2244
    
    GHC Trac Issues: #4012


>---------------------------------------------------------------

4c6e69d58a300d6ef440d326a3fd29b58b284fa1
 compiler/basicTypes/DataCon.hs   |  5 ++--
 compiler/basicTypes/Demand.hs    | 14 ++++++++---
 compiler/basicTypes/NameEnv.hs   |  5 +---
 compiler/basicTypes/NameSet.hs   |  4 +---
 compiler/basicTypes/VarEnv.hs    | 12 ++--------
 compiler/basicTypes/VarSet.hs    |  4 +---
 compiler/codeGen/StgCmmEnv.hs    |  4 +++-
 compiler/deSugar/Desugar.hs      |  4 +++-
 compiler/main/HscMain.hs         |  4 +++-
 compiler/rename/RnSource.hs      |  4 +++-
 compiler/simplCore/OccurAnal.hs  | 10 +++++---
 compiler/simplCore/SetLevels.hs  |  5 ++--
 compiler/specialise/Rules.hs     |  4 +++-
 compiler/typecheck/TcSimplify.hs |  5 +++-
 compiler/types/Coercion.hs       |  6 ++++-
 compiler/types/TyCoRep.hs        |  4 +++-
 compiler/types/Unify.hs          | 14 ++++++++---
 compiler/utils/FastStringEnv.hs  |  5 +---
 compiler/utils/UniqFM.hs         | 51 ++++++++++++++++++++--------------------
 19 files changed, 93 insertions(+), 71 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 4c6e69d58a300d6ef440d326a3fd29b58b284fa1