[commit: ghc] master: Document SCC determinism (3edbd09)

git at git.haskell.org git at git.haskell.org
Wed May 11 15:20:08 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/3edbd091341ab0ab60862ba18d3107f34c7fc876/ghc

>---------------------------------------------------------------

commit 3edbd091341ab0ab60862ba18d3107f34c7fc876
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Wed May 11 07:47:47 2016 -0700

    Document SCC determinism
    
    I've documented the guarantees that stronglyConnCompFromEdgedVertices
    provides and commented on the call sites to explain why they are
    OK from determinism standpoint. I've changed the functions to
    nonDetUFM versions, so that it's explicit they could introduce
    nondeterminism.  I haven't defined container (VarSet, NameSet)
    specific versions, so that we have less functions to worry about.
    
    Test Plan: this is mostly just documentation,
    it should have no runtime effect
    
    Reviewers: bgamari, simonmar, austin, simonpj
    
    Reviewed By: simonpj
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2194
    
    GHC Trac Issues: #4012


>---------------------------------------------------------------

3edbd091341ab0ab60862ba18d3107f34c7fc876
 compiler/basicTypes/NameEnv.hs                | 10 ++++++++++
 compiler/iface/MkIface.hs                     |  8 +++++++-
 compiler/rename/RnBinds.hs                    |  5 ++++-
 compiler/rename/RnSource.hs                   |  7 ++++++-
 compiler/simplCore/OccurAnal.hs               | 11 +++++++++--
 compiler/typecheck/TcBinds.hs                 |  6 +++++-
 compiler/typecheck/TcEvidence.hs              |  8 ++++++--
 compiler/typecheck/TcSMonad.hs                |  6 +++++-
 compiler/typecheck/TcTyDecls.hs               | 23 ++++++++++++++++++++---
 compiler/utils/Digraph.hs                     | 15 +++++++++++++++
 compiler/utils/UniqFM.hs                      | 12 ++++++++++--
 compiler/vectorise/Vectorise/Type/Classify.hs |  6 +++++-
 12 files changed, 102 insertions(+), 15 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 3edbd091341ab0ab60862ba18d3107f34c7fc876


More information about the ghc-commits mailing list