[commit: ghc] master: Improve the error messages for static forms. (e9dfb6e)

git at git.haskell.org git at git.haskell.org
Thu Jun 9 16:27:21 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/e9dfb6e51f0cd585611a742ce7167e307ee7e7e8/ghc

>---------------------------------------------------------------

commit e9dfb6e51f0cd585611a742ce7167e307ee7e7e8
Author: Facundo Domínguez <facundo.dominguez at tweag.io>
Date:   Thu Jun 9 17:37:42 2016 +0200

    Improve the error messages for static forms.
    
    Now the message explains why closed variables are not closed when
    encountered in the body of (static ...).
    
    This required adding to the local environment the free variables of
    the local bindings in scope. Thus we can analyze and explain why a
    variable is not closed when encountered.
    
    Test Plan: ./validate
    
    Reviewers: austin, simonpj, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: mboes, thomie
    
    Differential Revision: https://phabricator.haskell.org/D2167
    
    GHC Trac Issues: #12003


>---------------------------------------------------------------

e9dfb6e51f0cd585611a742ce7167e307ee7e7e8
 compiler/typecheck/TcBinds.hs                      |  47 ++++---
 compiler/typecheck/TcEnv.hs                        |  48 ++++---
 compiler/typecheck/TcExpr.hs                       | 155 ++++++++++++++++++++-
 compiler/typecheck/TcRnDriver.hs                   |   5 +-
 compiler/typecheck/TcRnTypes.hs                    |  48 ++++++-
 .../should_fail/RnStaticPointersFail01.stderr      |   3 +-
 .../rename/should_fail/RnStaticPointersFail03.hs   |   9 ++
 .../should_fail/RnStaticPointersFail03.stderr      |  35 +++--
 testsuite/tests/rename/should_fail/all.T           |   2 +-
 9 files changed, 288 insertions(+), 64 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc e9dfb6e51f0cd585611a742ce7167e307ee7e7e8


More information about the ghc-commits mailing list