[commit: ghc] master: Make Data.{Bifoldable, Bitraversable} -XSafe (e46b768)

git at git.haskell.org git at git.haskell.org
Wed Jul 20 13:17:00 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/e46b76816c67ca8651aaf2c119632ff1bdb3766f/ghc

>---------------------------------------------------------------

commit e46b76816c67ca8651aaf2c119632ff1bdb3766f
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date:   Wed Jul 20 09:15:56 2016 -0400

    Make Data.{Bifoldable,Bitraversable} -XSafe
    
    Test Plan:
    Previously, `Data.{Bifoldable,Bitraversable}` were being inferred as
    `Unsafe` due to a transitive `Data.Coerce` import from `Data.Functor.Utils`.
    This rectifies this unfortunate mistake.
    
    Reviewers: austin, hvr, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie, phadej
    
    Differential Revision: https://phabricator.haskell.org/D2412


>---------------------------------------------------------------

e46b76816c67ca8651aaf2c119632ff1bdb3766f
 libraries/base/Data/Bifoldable.hs    | 1 +
 libraries/base/Data/Bitraversable.hs | 2 ++
 libraries/base/Data/Functor/Utils.hs | 1 +
 3 files changed, 4 insertions(+)

diff --git a/libraries/base/Data/Bifoldable.hs b/libraries/base/Data/Bifoldable.hs
index 11a1c25..9006e61 100644
--- a/libraries/base/Data/Bifoldable.hs
+++ b/libraries/base/Data/Bifoldable.hs
@@ -1,3 +1,4 @@
+{-# LANGUAGE Safe #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 
 -----------------------------------------------------------------------------
diff --git a/libraries/base/Data/Bitraversable.hs b/libraries/base/Data/Bitraversable.hs
index 42e9635..f185044 100644
--- a/libraries/base/Data/Bitraversable.hs
+++ b/libraries/base/Data/Bitraversable.hs
@@ -1,3 +1,5 @@
+{-# LANGUAGE Safe #-}
+
 -----------------------------------------------------------------------------
 -- |
 -- Module      :  Data.Bitraversable
diff --git a/libraries/base/Data/Functor/Utils.hs b/libraries/base/Data/Functor/Utils.hs
index e24d235..79b3418 100644
--- a/libraries/base/Data/Functor/Utils.hs
+++ b/libraries/base/Data/Functor/Utils.hs
@@ -1,3 +1,4 @@
+{-# LANGUAGE Trustworthy #-}
 {-# LANGUAGE NoImplicitPrelude #-}
 
 -----------------------------------------------------------------------------



More information about the ghc-commits mailing list