[commit: ghc] wip/ghc-8.0-det: Kill varSetElems in tidyFreeTyCoVars (28aabfc)

git at git.haskell.org git at git.haskell.org
Mon Jul 18 17:58:27 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ghc-8.0-det
Link       : http://ghc.haskell.org/trac/ghc/changeset/28aabfcb609cb784b72d8746a8a681c487db0e16/ghc

>---------------------------------------------------------------

commit 28aabfcb609cb784b72d8746a8a681c487db0e16
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Wed May 18 10:36:49 2016 -0700

    Kill varSetElems in tidyFreeTyCoVars
    
    I haven't observed this to have an effect on nondeterminism,
    but tidyOccName appears to modify the TidyOccEnv in a
    way dependent on the order of inputs.
    It's easy enough to change it to be deterministic to be on the
    safe side.
    
    Test Plan: ./validate
    
    Reviewers: simonmar, austin, bgamari, simonpj
    
    Reviewed By: simonpj
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2238
    
    GHC Trac Issues: #4012


>---------------------------------------------------------------

28aabfcb609cb784b72d8746a8a681c487db0e16
 compiler/typecheck/TcErrors.hs                     |   8 +-
 compiler/typecheck/TcRnMonad.hs                    |   2 +-
 compiler/typecheck/TcValidity.hs                   |  10 +-
 compiler/types/TyCoRep.hs                          |   8 +-
 .../tests/indexed-types/should_fail/T2693.stderr   |   4 +-
 .../should_fail/overloadedlabelsfail01.stderr      |  46 ++--
 testsuite/tests/parser/should_fail/T7848.stderr    |   4 +-
 testsuite/tests/rename/should_fail/T10618.stderr   |   2 +-
 .../tests/typecheck/should_fail/T11355.stderr      |   2 +-
 testsuite/tests/typecheck/should_fail/T5684.stderr | 286 ++++++++++-----------
 testsuite/tests/typecheck/should_fail/T7851.stderr |   4 +-
 .../tests/typecheck/should_fail/tcfail001.stderr   |   2 +-
 12 files changed, 189 insertions(+), 189 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 28aabfcb609cb784b72d8746a8a681c487db0e16


More information about the ghc-commits mailing list