[commit: ghc] master: Show error message for unknown symbol on Elf_Rel platforms (5c82333)

git at git.haskell.org git at git.haskell.org
Mon Jan 25 14:13:12 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/5c8233388983a5af9fda5f3395ad28f4e0392f98/ghc

>---------------------------------------------------------------

commit 5c8233388983a5af9fda5f3395ad28f4e0392f98
Author: Reid Barton <rwbarton at gmail.com>
Date:   Mon Jan 25 09:12:40 2016 -0500

    Show error message for unknown symbol on Elf_Rel platforms
    
    Summary: This is already the behavior on Elf_Rela platforms, and is helpful.
    
    Reviewers: simonmar, austin, bgamari, erikd
    
    Reviewed By: erikd
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1841


>---------------------------------------------------------------

5c8233388983a5af9fda5f3395ad28f4e0392f98
 rts/Linker.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/rts/Linker.c b/rts/Linker.c
index 1c76a00..b9a1d34 100644
--- a/rts/Linker.c
+++ b/rts/Linker.c
@@ -5009,7 +5009,6 @@ do_Elf_Rel_relocations ( ObjectCode* oc, char* ehdrC,
          } else {
             symbol = strtab + sym.st_name;
             S_tmp = lookupSymbol_( symbol );
-            if (S_tmp == NULL) return 0;
             S = (Elf_Addr)S_tmp;
          }
          if (!S) {



More information about the ghc-commits mailing list